Merge pull request #19 from ScriptedAlchemy/test/workbench-route-helpers

test(workbench): adopt the shared packed-release harness and route helper

Author: ScriptedAlchemy

packages/workbench/tests/artifacts-real.e2e.test.ts

@@ -3,7 +3,7 @@ import { expect } from '@rstest/playwright';
 import { createWorkbenchAssetSource } from '../../agent-bundle/src/dev/workbench-assets.ts';
 import { startDevServer } from '../../agent-bundle/src/dev/workbench-server.ts';
 import { createProjectFixture, removeProjectFixture } from '../../agent-bundle/tests/helpers/project-fixture.ts';
-import { buildWorkbench, e2e, workbenchAssets } from './support/workbench-e2e.ts';
+import { buildWorkbench, e2e, workbenchAssets, workbenchUrl } from './support/workbench-e2e.ts';
 
 const browserTimeout = 12_000;
 
@@ -19,7 +19,7 @@ e2e('contains the mounted Artifacts page and its table at desktop and 390px widt
   try {
     const pageErrors: Error[] = [];
     page.on('pageerror', (error) => pageErrors.push(error));
-    await page.goto(`${server.url}#artifacts`);
+    await page.goto(workbenchUrl(server.url, 'artifacts'));
     await expect(page.getByRole('heading', { name: 'Artifacts' })).toBeVisible({ timeout: browserTimeout });
     await expect(page.locator('.artifact-table').first()).toBeVisible({ timeout: browserTimeout });
     expect(await page.evaluate(() => document.documentElement.scrollWidth <= window.innerWidth)).toBe(true);

packages/workbench/tests/evals-real.e2e.test.ts

@@ -15,7 +15,7 @@ import { seedEvalProject, writeEvalSuite } from '../../agent-bundle/tests/suppor
 import { readFinalizedEvalRun } from '../src/evals/evals-page.tsx';
 import { closeServer } from './support/http.ts';
 import { workbenchBrowserAliases } from './support/workbench-browser-modules.ts';
-import { buildWorkbench, e2e, workbenchAssets, workspaceRoot } from './support/workbench-e2e.ts';
+import { buildWorkbench, e2e, workbenchAssets, workspaceRoot, workbenchUrl } from './support/workbench-e2e.ts';
 
 const evalsPage = join(workspaceRoot, 'packages', 'workbench', 'src', 'evals', 'evals-page.tsx');
 const browserTimeout = 12_000;
@@ -228,7 +228,7 @@ e2e('admits a deterministic Eval promptly and renders refreshed durable evidence
     page.on('request', (request) => {
       if (request.method() === 'GET' && request.url().includes('/api/evals/runs/')) durableReads.push(request.url());
     });
-    await page.goto(`${server.url}#evals`);
+    await page.goto(workbenchUrl(server.url, 'evals'));
     await expect(page.getByRole('heading', { name: 'Evals' })).toBeVisible({ timeout: browserTimeout });
     await expect(page.getByRole('button', { name: 'Run deterministic suite' })).toBeEnabled({ timeout: browserTimeout });
     await expect(page.getByLabel('Harness')).toHaveValue('deterministic');
@@ -326,7 +326,7 @@ e2e('keeps a gated deterministic run cancellable exactly once and rejects stale
       await heldCancel;
       await route.continue();
     });
-    await page.goto(`${server.url}#evals`);
+    await page.goto(workbenchUrl(server.url, 'evals'));
     await expect(page.getByRole('heading', { name: 'Evals' })).toBeVisible({ timeout: browserTimeout });
     await page.getByLabel('Suite').selectOption('gated-cancel');
     const admitted = page.waitForResponse((response) =>
@@ -381,7 +381,7 @@ e2e('does not cancel a gated run when a newer admission replaces it or the Eval
     page.on('request', (request) => {
       if (request.method() === 'POST' && request.url().includes('/cancel')) cancellations += 1;
     });
-    await page.goto(`${server.url}#evals`);
+    await page.goto(workbenchUrl(server.url, 'evals'));
     await expect(page.getByRole('heading', { name: 'Evals' })).toBeVisible({ timeout: browserTimeout });
     await page.getByLabel('Suite').selectOption('gated-cancel');
     const firstAdmission = page.waitForResponse((response) =>
@@ -397,7 +397,7 @@ e2e('does not cancel a gated run when a newer admission replaces it or the Eval
     await expect(page.locator('.eval-summary')).toContainText(replacement.run.id, { timeout: browserTimeout });
     await page.waitForTimeout(150);
     await expect(page.locator('.eval-summary')).not.toContainText(first.run.id);
-    await page.goto(`${server.url}#overview`);
+    await page.goto(workbenchUrl(server.url, 'overview'));
     await expect(page.getByRole('heading', { name: 'Bundle dashboard' })).toBeVisible({ timeout: browserTimeout });
     expect(cancellations).toBe(0);
   } finally {

packages/workbench/tests/examples-real.e2e.test.ts

@@ -14,7 +14,7 @@ import {
   waitForSettledWorkbench,
   writeExampleReport,
 } from './support/example-acceptance.ts';
-import { buildWorkbench, e2e, workbenchAssets } from './support/workbench-e2e.ts';
+import { buildWorkbench, e2e, workbenchAssets, workbenchUrl } from './support/workbench-e2e.ts';
 
 const browserTimeout = 15_000;
 
@@ -48,7 +48,7 @@ e2e('drives the populated Skills Starter in real Chrome', { timeout: 90_000 }, a
   });
   const ledger = createExampleErrorLedger(page, server.url);
   try {
-    await page.goto(`${server.url}#skills`);
+    await page.goto(workbenchUrl(server.url, 'skills'));
     await waitForSettledWorkbench(page);
     await expect(page.getByRole('heading', { name: 'dependency-upgrade', exact: true })).toBeVisible({ timeout: browserTimeout });
     await expect(page.locator('.skill-tree-item')).toHaveCount(3, { timeout: browserTimeout });
@@ -73,7 +73,7 @@ e2e('drives the populated Skills Starter in real Chrome', { timeout: 90_000 }, a
     );
     await captureExampleState(page, 'skills-starter', 'skills-populated');
 
-    await page.goto(`${server.url}#hooks`);
+    await page.goto(workbenchUrl(server.url, 'hooks'));
     await waitForSettledWorkbench(page);
     await expect(page).toHaveURL(new URL('#overview', server.url).href, { timeout: browserTimeout });
     await expect(page.getByRole('heading', { name: 'Bundle dashboard', exact: true })).toBeVisible({ timeout: browserTimeout });
@@ -126,7 +126,7 @@ e2e('reveals, retains, repairs, and removes capabilities without reloading Chrom
     expect(status).toBe(200);
   };
   try {
-    await page.goto(`${server.url}#hooks`);
+    await page.goto(workbenchUrl(server.url, 'hooks'));
     await waitForSettledWorkbench(page);
     await expect(page).toHaveURL(new URL('#overview', server.url).href, { timeout: browserTimeout });
     await expect(page.getByRole('link', { name: 'Hooks', exact: true })).toHaveCount(0, { timeout: browserTimeout });
@@ -187,7 +187,7 @@ e2e('drives Hooks, scripts, logs, diagnostics, and repair in real Chrome', { tim
   });
   const ledger = createExampleErrorLedger(page, server.url);
   try {
-    await page.goto(`${server.url}#hooks`);
+    await page.goto(workbenchUrl(server.url, 'hooks'));
     await waitForSettledWorkbench(page);
     await expect(page.locator('#hook-binding option')).not.toHaveCount(0, { timeout: browserTimeout });
     const canonicalHookDraft = JSON.stringify({
@@ -285,7 +285,7 @@ e2e('drives every populated MCP App workflow surface in real Chrome', { timeout:
   });
   const ledger = createExampleErrorLedger(page, server.url);
   try {
-    await page.goto(`${server.url}#overview`);
+    await page.goto(workbenchUrl(server.url, 'overview'));
     await waitForSettledWorkbench(page);
     await expect(page.getByRole('heading', { name: 'Bundle dashboard', exact: true })).toBeVisible({ timeout: browserTimeout });
     await expect(page.getByText('See what this bundle publishes, try supported workflows, and rebuild after source changes.', { exact: true })).toBeVisible({ timeout: browserTimeout });

packages/workbench/tests/inspector-shell.e2e.test.ts

@@ -7,7 +7,7 @@ import { agentBundleNodeModules, workbenchNodeModules } from '../../agent-bundle
 import { createWorkbenchAssetSource } from '../../agent-bundle/src/dev/workbench-assets.ts';
 import { startDevServer } from '../../agent-bundle/src/dev/workbench-server.ts';
 import { createProjectFixture, removeProjectFixture } from '../../agent-bundle/tests/helpers/project-fixture.ts';
-import { e2e, execFile, workbenchAssets, workspaceRoot } from './support/workbench-e2e.ts';
+import { e2e, execFile, workbenchAssets, workspaceRoot, workbenchUrl } from './support/workbench-e2e.ts';
 
 const browserTimeout = 5_000;
 
@@ -83,7 +83,7 @@ e2e('treats an unsupported Inspector hash as the overview without opening an MCP
       if (request.url() === `${server.url}/api/mcp/sessions` && request.method() === 'POST') sessionPosts += 1;
     });
 
-    await page.goto(`${server.url}#inspector`);
+    await page.goto(workbenchUrl(server.url, 'inspector'));
     await expect(page).toHaveURL(/#inspector$/u, { timeout: browserTimeout });
     await expect(page.getByRole('heading', { name: 'Bundle dashboard' })).toBeVisible({ timeout: browserTimeout });
     await expect(page.getByRole('link', { name: 'Overview' })).toHaveAttribute('aria-current', 'page');
@@ -114,7 +114,7 @@ e2e('shares one real session between the MCP Playground and Inspector presentati
       if (request.url() === `${server.url}/api/mcp/sessions` && request.method() === 'POST') sessionPosts += 1;
     });
 
-    await page.goto(`${server.url}#mcp`);
+    await page.goto(workbenchUrl(server.url, 'mcp'));
     const playgroundTab = page.getByRole('tab', { name: 'Playground' });
     const inspectorTab = page.getByRole('tab', { name: 'Inspector' });
     const presentationHistoryLength = await page.evaluate(() => window.history.length);
@@ -246,7 +246,7 @@ e2e('mounts the internal Inspector presentation from an explicit development-mod
   try {
     const pageErrors: Error[] = [];
     page.on('pageerror', (error) => pageErrors.push(error));
-    await page.goto(`${server.url}#mcp`);
+    await page.goto(workbenchUrl(server.url, 'mcp'));
     const inspectorTab = page.getByRole('tab', { name: 'Inspector' });
     await inspectorTab.click();
     await expect(inspectorTab).toHaveAttribute('aria-selected', 'true');

packages/workbench/tests/logs-real.e2e.test.ts

@@ -5,7 +5,7 @@ import { expect } from '@rstest/playwright';
 import { createWorkbenchAssetSource } from '../../agent-bundle/src/dev/workbench-assets.ts';
 import { startDevServer } from '../../agent-bundle/src/dev/workbench-server.ts';
 import { createProjectFixture, removeProjectFixture } from '../../agent-bundle/tests/helpers/project-fixture.ts';
-import { buildWorkbench, e2e, workbenchAssets } from './support/workbench-e2e.ts';
+import { buildWorkbench, e2e, workbenchAssets, workbenchUrl } from './support/workbench-e2e.ts';
 
 const browserTimeout = 12_000;
 
@@ -25,7 +25,7 @@ e2e('shows real producer logs with replay, filters, redaction, responsive layout
       const url = new URL(response.url());
       return url.origin === server.url && url.pathname === '/api/logs/replay' && url.searchParams.get('after') === '0' && response.ok();
     });
-    await page.goto(`${server.url}#logs`);
+    await page.goto(workbenchUrl(server.url, 'logs'));
     await expect(page.getByRole('heading', { name: 'Logs' })).toBeVisible({ timeout: browserTimeout });
     const replay = await (await replayed).json() as { readonly replay: Readonly<{ readonly records: readonly unknown[] }> };
     expect(replay.replay.records.length).toBeGreaterThan(0);
@@ -40,9 +40,9 @@ e2e('shows real producer logs with replay, filters, redaction, responsive layout
     await expect(page.locator('.logs-entry-source').first()).toHaveText('project', { timeout: browserTimeout });
     await page.locator('#logs-producer').selectOption('');
     const replayCount = await page.locator('.logs-entries > li').count();
-    await page.goto(`${server.url}#overview`);
+    await page.goto(workbenchUrl(server.url, 'overview'));
     await expect(page.getByRole('heading', { name: 'Bundle dashboard' })).toBeVisible({ timeout: browserTimeout });
-    await page.goto(`${server.url}#logs`);
+    await page.goto(workbenchUrl(server.url, 'logs'));
     await expect(page.getByRole('heading', { name: 'Logs' })).toBeVisible({ timeout: browserTimeout });
     const replayedSequences = await page.waitForFunction(
       ({ count, selector }) => {

packages/workbench/tests/mcp-app-real.e2e.test.ts

@@ -11,6 +11,7 @@ import { createWorkbenchAssetSource } from '../../agent-bundle/src/dev/workbench
 import { startDevServer } from '../../agent-bundle/src/dev/workbench-server.ts';
 import { createProjectFixture, removeProjectFixture } from '../../agent-bundle/tests/helpers/project-fixture.ts';
 import { startRuntimePlaygroundFixture } from './helpers/runtime-playground-fixture.ts';
+import { workbenchUrl } from './support/workbench-e2e.ts';
 
 const workspaceRoot = process.cwd();
 const workbenchAssets = join(workspaceRoot, 'packages', 'workbench', 'dist');
@@ -255,7 +256,7 @@ e2e('runs a generated SDK-v2 App through the real foreground session and separat
       }).catch(() => undefined);
     });
 
-    await page.goto(`${foregroundOrigin}#mcp`);
+    await page.goto(workbenchUrl(foregroundOrigin, 'mcp'));
     await expect(page.getByRole('heading', { name: 'MCP playground' })).toBeVisible({ timeout: browserTimeout });
     await page.locator('#mcp-target').selectOption('portable');
     await page.locator('#mcp-server-name').fill('fixture');
@@ -553,7 +554,7 @@ e2e('opens the real RSC runtime timeline App from provider-owned run evidence',
     }).catch(() => undefined);
   });
   try {
-    await page.goto(`${fixture.url}#runtime`);
+    await page.goto(workbenchUrl(fixture.url, 'runtime'));
     await expect(page.getByRole('heading', { name: 'Runtime Playground' })).toBeVisible({ timeout: 15_000 });
     const runtimeIdentity = page.locator('[data-runtime-provider-session]');
     const runtimeSurface = page.getByLabel('Runtime surface');
@@ -1430,7 +1431,7 @@ e2e('keeps Portable, ChatGPT, and Claude simulated App profiles isolated over on
     }).catch(() => undefined);
   });
   try {
-    await page.goto(`${fixture.url}#runtime`);
+    await page.goto(workbenchUrl(fixture.url, 'runtime'));
     await expect(page.getByRole('heading', { name: 'Runtime Playground' })).toBeVisible({ timeout: 15_000 });
     const runtimeIdentity = page.locator('[data-runtime-provider-session]');
     const runtimeSurface = page.getByLabel('Runtime surface');
@@ -1648,7 +1649,7 @@ e2e('renders a compiler-bundled App template through the canonical sandbox URL',
       }
     });
 
-    await page.goto(`${foregroundOrigin}#mcp`);
+    await page.goto(workbenchUrl(foregroundOrigin, 'mcp'));
     await expect(page.getByRole('heading', { name: 'MCP playground' })).toBeVisible({ timeout: browserTimeout });
     await page.locator('#mcp-target').selectOption('portable');
     await page.locator('#mcp-server-name').fill('fixture');