Cannot switch to default category

[Morkovka21Vek]

You cannot switch back to the default category after changing to another one.

[coderPaddyS]

I cannot reproduce your issue. Is it in the note overview (so by selecting a different category in the menu), in the note editing or in the creation of notes? In all I can change back to the default note category.

[Morkovka21Vek]

I found the problem area.

privacy-friendly-notes/app/src/main/java/org/secuso/privacyfriendlynotes/ui/notes/BaseNoteActivity.kt

Lines 154 to 167 in 25a144a

	catSelection.setOnDismissListener {
	val catName = catSelection.text.toString()
	if (catName == getString(R.string.default_category)) {
	currentCat = 0
	return@setOnDismissListener
	}
	currentCat = -1
	for (cat: Category in allCategories!!) {
	if (catName == cat.name) {
	currentCat = cat._id
	}
	}
	hasChanged = true
	}

If you change the category to the default category but don't change anything else in the note, the hasChanged flag will not be set to true.

Also, if you select the current category from the list, the hasChanged flag will be set to true, although it shouldn't.

[coderPaddyS]

Whilst the things you've mentioned are true, and are minor inconveniences if the note is saved more often than needed, this does explain your earlier mentioned issue you've encountered. Could you please explain what you meant?

[Morkovka21Vek]

Sorry for the confusion earlier.

The issue is directly related to hasChanged.

Steps to reproduce:

1. Create a note
2. Change the category to any other
3. Save
4. Reopen the note
5. Change the category back to "default"
6. Do not modify anything else
7. Save

Expected behavior:
The category should change back to "default".

Actual behavior:
The category does not change and remains the previous one.

Cause:
When selecting the default category, the following code is executed:

privacy-friendly-notes/app/src/main/java/org/secuso/privacyfriendlynotes/ui/notes/BaseNoteActivity.kt

Lines 156 to 159 in 25a144a

	if (catName == getString(R.string.default_category)) {
	currentCat = 0
	return@setOnDismissListener
	}

Due to the early return, the hasChanged flag is not set to true.

As a result, the system assumes there are no changes and does not persist the updated category.

[coderPaddyS]

Okay, that is something I can understand and reproduce. Thank you very much for the effort in reporting this issue and thinking of a solution. This will be fixed in the next release.