-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Open
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!C-rbRuby BindingsRuby BindingsD-firefoxI-defectSomething is not working as intendedSomething is not working as intendedI-regressionSomething was working but we "fixed" itSomething was working but we "fixed" itOS-linux
Description
Description
What I saw:
Due to a recent change in the JSON module, which is a dependency, when a non UTF-8 value reaches Selenium::WebDriver::Remote::Http::Common then a warning is thrown:
warning: JSON.generate: UTF-8 string passed as BINARY, this will raise an encoding error in json 3.0
What I would expect:
Values are encoded as UTF-8 before being passed on to the JSON.generate call, or otherwise if they fail encoding, an error is raised.
Reproducible Code
Selenium::WebDriver::Driver.execute_script( 'return navigator.userAgent;'.force_encoding( Encoding::BINARY ) )ℹ️ Last known working version: It is an issue with the JSON dependency, which has changed.
Metadata
Metadata
Assignees
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!C-rbRuby BindingsRuby BindingsD-firefoxI-defectSomething is not working as intendedSomething is not working as intendedI-regressionSomething was working but we "fixed" itSomething was working but we "fixed" itOS-linux