Certificate verification checks status but not expiry

[feyishola]

findByVerificationCode in certificate-verification.service.ts:21-38 filters on status = 'active' but never checks expiresAt, even though the entity exposes an isExpired() getter (certificate.entity.ts:174-177). Any certificate whose expiresAt has passed but which has not yet been swept by the expiration job verifies as fully valid and even emits a CERTIFICATE_VERIFIED webhook. Fix: add AND (certificate.expiresAt IS NULL OR certificate.expiresAt > NOW()) to the query, or reject when isExpired().

[drips-wave]

Congratulations, @chainsmt! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @chainsmt: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[babatundealao407-alt]

@babatundealao407-alt has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’m interested in taking this issue and have reviewed the requirements carefully. I’d like to approach the implementation methodically, with attention to existing conventions, edge cases, and the overall stability of the codebase.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @babatundealao407-alt to this issue.

[drips-wave]

Congratulations, @babatundealao407-alt! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @babatundealao407-alt: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊