Skip to content

propose_certificate performs no caller authorization (impersonation / spam) #797

Description

@feyishola

Neither propose_certificate implementation calls issuer.require_auth() — in lib.rs the intended call is the orphaned stray statement at line 879 (outside the function), and multisig.rs:122-168 has none. Any account can create a PendingRequest naming an arbitrary issuer/proposer and pollute that issuer's and its signers' request indexes (IssuerRequestIds/SignerRequestIds) — an unauthenticated spam/DoS vector against paginated queries. Fix: add issuer.require_auth(); as the first line of both functions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions