You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When reviewing PR #898 (which tried to add npm run lint steps to CI), we found eslint --max-warnings 0 currently fails on the existing codebase, so the lint gates were deferred to keep CI green. This issue tracks clearing that lint debt so the gates can be re-added.
Files export both a component and non-component values (common in context/provider/util files). Either split non-component exports into separate modules, or scope/relax this rule for those files (it is an HMR-only concern).
5
react/no-unescaped-entities
Unescaped '/" in JSX text — replace with '/" or wrap in {'...'}.
Backend — 17 errors
Includes:
@typescript-eslint/require-await (×4) — async functions with no await; drop async or add the awaited call.
no-useless-escape (×3) — remove unnecessary escapes in regex/strings.
@typescript-eslint/no-misused-promises (×2) — promises passed where a void-returning callback is expected; wrap/await appropriately.
plus a few others (run the command above for the full list).
Definition of done
cd frontend && npm run lint and cd backend && npm run lint both pass with --max-warnings 0.
Note: the frontend react-refresh/only-export-components count is large but mostly mechanical / a lint-config decision; consider tackling it separately from the handful of genuine code fixes.
Context
When reviewing PR #898 (which tried to add
npm run lintsteps to CI), we foundeslint --max-warnings 0currently fails on the existing codebase, so the lint gates were deferred to keep CI green. This issue tracks clearing that lint debt so the gates can be re-added.Reproduce:
Frontend — 77 errors
react-refresh/only-export-componentsreact/no-unescaped-entities'/"in JSX text — replace with'/"or wrap in{'...'}.Backend — 17 errors
Includes:
@typescript-eslint/require-await(×4) —asyncfunctions with noawait; dropasyncor add the awaited call.no-useless-escape(×3) — remove unnecessary escapes in regex/strings.@typescript-eslint/no-misused-promises(×2) — promises passed where a void-returning callback is expected; wrap/await appropriately.Definition of done
cd frontend && npm run lintandcd backend && npm run lintboth pass with--max-warnings 0.Lint frontend/Lint backendsteps to.github/workflows/ci.yml(thefrontendandbackendjobs) — these were intentionally left out of fix(ci): fix cache-dependency-paths and add lint and typecheck steps #898.Note: the frontend
react-refresh/only-export-componentscount is large but mostly mechanical / a lint-config decision; consider tackling it separately from the handful of genuine code fixes.