Commit 4da0793
DEV-1013 Migrate three modules off APIs Gradle 7 removed
Aligning the wrappers is not enough on its own: ShimmerTCP, JavaShimmerConnect
and ShimmerLSL still used the `compile`/`testCompile` configurations and, in
ShimmerLSL's case, the `maven` plugin - all removed in Gradle 7.
ShimmerTCP and JavaShimmerConnect are leaf modules that publish nothing, so
`compile` becomes `implementation`. ShimmerLSL does publish, so `compile`
becomes `api` (with `java-library` applied) to keep its POM dependencies in
`compile` scope rather than demoting them to `runtime`.
Also replaced jcenter(), shut down in 2022, with mavenCentral(), and dropped
JavaShimmerConnect's dead bintray repository - bintray closed in 2021, and its
plain http:// URL is rejected by Gradle 7+ anyway.
ShimmerLSL declared source/targetCompatibility 1.8 while depending on
ShimmerDriver, ShimmerDriverPC and ShimmerBluetoothManager, which are all built
for Java 11. Gradle 2.14.1 had no variant-aware matching so never checked this;
8.14.3 does, and rejects it. The 1.8 declaration was never satisfiable - a Java
8 consumer could not have used this module - so it now states 1.11. This is the
one consumer-visible change here.
All seven modules now clean-build. Before this, every one of them was broken:
the 6.1 modules on the Guava variant fault, ShimmerPCBasicExamples because
Shadow 7.0.0 cannot be applied under Gradle 6.1, and ShimmerLSL because Gradle
2.14.1 cannot parse a JDK 11 version string.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 950406d commit 4da0793
3 files changed
Lines changed: 20 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | 21 | | |
25 | 22 | | |
26 | 23 | | |
27 | 24 | | |
28 | 25 | | |
29 | | - | |
| 26 | + | |
30 | 27 | | |
31 | 28 | | |
32 | 29 | | |
33 | 30 | | |
34 | 31 | | |
35 | 32 | | |
36 | 33 | | |
37 | | - | |
| 34 | + | |
38 | 35 | | |
39 | | - | |
40 | | - | |
41 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
42 | 39 | | |
43 | 40 | | |
44 | 41 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | | - | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
0 commit comments