From 46e7a3e467098cd2decef4ac701e361783e8d565 Mon Sep 17 00:00:00 2001 From: Katelyn Gigante Date: Sun, 11 Jan 2026 11:21:45 +1100 Subject: [PATCH 1/3] Fix crash when launching directly client from command line --- worlds/sims4/Client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/worlds/sims4/Client.py b/worlds/sims4/Client.py index 62d6164faac3..16b152f9ea75 100644 --- a/worlds/sims4/Client.py +++ b/worlds/sims4/Client.py @@ -252,7 +252,7 @@ async def game_watcher(ctx: SimsContext): await asyncio.sleep(0.5) -def main(args): +def main(args: list[str] | None = None) -> None: async def _main(): parser = get_base_parser(description="The Sims 4 Client, for text interfacing.") _args, _rest = parser.parse_known_args(args) From c4912f7a8cf17dd7aeb2a50903c0ca24696d00d6 Mon Sep 17 00:00:00 2001 From: Katelyn Gigante Date: Sun, 11 Jan 2026 11:22:22 +1100 Subject: [PATCH 2/3] Add an additional check that /set_path was given an absolute path --- worlds/sims4/Client.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/worlds/sims4/Client.py b/worlds/sims4/Client.py index 16b152f9ea75..e9cb1bf0d72d 100644 --- a/worlds/sims4/Client.py +++ b/worlds/sims4/Client.py @@ -92,11 +92,13 @@ def _cmd_set_path(self, sims_4_mods_path: str = ''): """Set the file path to the Sims 4 mods folder manually (if automatic detection fails)""" p = sims_4_mods_path global mod_data_path - if p == '': - self.output('no path inputed') + if not p: + self.output("no path inputed") elif os.path.exists(os.path.join(p, 'mod_data', 's4ap')): self.output('Sims 4 mods folder found') mod_data_path = os.path.join(p, 'mod_data', 's4ap') + elif not os.path.isabs(p): + self.output("Please enter the full path to the Sims 4 mods folder.\nFor example: C:\\Users\\Username\\Documents\\Electronic Arts\\The Sims 4\\Mods") else: self.ctx.gui_error(title='Sims 4 mods folder not found', text=f'Make sure the file path you inputed is correct.') From 09a1875dbdfcf9df6b984d875ea9c32ee887fd09 Mon Sep 17 00:00:00 2001 From: Katelyn Gigante Date: Sun, 11 Jan 2026 11:41:37 +1100 Subject: [PATCH 3/3] Update worlds/sims4/Client.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- worlds/sims4/Client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/worlds/sims4/Client.py b/worlds/sims4/Client.py index e9cb1bf0d72d..392cf1f5fb3d 100644 --- a/worlds/sims4/Client.py +++ b/worlds/sims4/Client.py @@ -93,7 +93,7 @@ def _cmd_set_path(self, sims_4_mods_path: str = ''): p = sims_4_mods_path global mod_data_path if not p: - self.output("no path inputed") + self.output("No path provided") elif os.path.exists(os.path.join(p, 'mod_data', 's4ap')): self.output('Sims 4 mods folder found') mod_data_path = os.path.join(p, 'mod_data', 's4ap')