upgrade_pool event does not include old WASM hash

[ritaifeoluwa]

Description

The Factory contract's upgrade_pool function does not emit an event with the old WASM hash. The event only includes the new hash, making it impossible to know what the pool was upgraded from.

Current behavior

env.events().publish(
    (symbol_short!("factory"), symbol_short!("pool_upg")),
    (pool_id, record.address, new_wasm_hash),
);

Expected behavior

Include the old hash:

let old_hash = env.deployer().get_wasm_hash(&record.address);
env.events().publish(
    (symbol_short!("factory"), symbol_short!("pool_upg")),
    (pool_id, record.address, old_hash, new_wasm_hash),
);

Why this matters

Off-chain indexers need both hashes for rollback scenarios and audit trails.

Labels

enhancement, factory, good first issue

[johnbiliyaminu-bit]

@johnbiliyaminu-bit has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I would love to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @johnbiliyaminu-bit to this issue.

[Bouynaty]

@Bouynaty has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello, I’m eager to contribute to the project and would really appreciate the chance to tackle this issue. Thanks for considering me!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Bouynaty to this issue.

[drips-wave]

Congratulations, @chainsmt! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @chainsmt: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[nanaabdul1172]

@nanaabdul1172 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer I have thoroughly read the description to this issue and I can resolve this according to the description required ensuring it meet all the acceptance criteria kindly assign..

ℹ️ Repo Maintainers: To accept this application, review their application or assign @nanaabdul1172 to this issue.

[ollypee22]

@ollypee22 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I would like to work on this issue please assign it to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @ollypee22 to this issue.

[ZacLou]

I'd like to work on this issue. I'll review the requirements and open a PR shortly.

[ZacLou]

Hi, I took a look at this and it appears the current main branch already includes the old WASM hash in the upgrade_pool event.

In soroban/contracts/factory/src/lib.rs around line 781 the code captures let old_hash = record.wasm_hash.clone();, and the event at line 816-819 is published as (pool_id, record.address, old_hash, new_wasm_hash) under the ('factory', 'pool_upg') topic.

Could you confirm whether this issue is fully resolved? If so, I am happy for it to be closed so the bounty can be awarded or redirected.