From 7cd3267e05b15e055e0e704629c4e67724b8be5b Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sun, 6 Sep 2026 15:25:43 -0700 Subject: [PATCH] fix mismatched 'open_scope'/'close_scope' when SMT-simplifying MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I believe this had no visible effect, because nothing is ever written to the solver after the second `open_scope`. But still this appears to have been a typo. Github: fixes #346 “SMT simplification appears to end with an open scope” --- rumur/src/smt/simplify.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rumur/src/smt/simplify.cc b/rumur/src/smt/simplify.cc index 61f94390..1e9d1231 100644 --- a/rumur/src/smt/simplify.cc +++ b/rumur/src/smt/simplify.cc @@ -235,7 +235,7 @@ class Simplifier : public BaseTraversal { if (auto f = dynamic_cast(c.get())) declare_func(*f); } - solver->open_scope(); + solver->close_scope(); } void visit_mul(Mul &n) final { visit_bexpr(n); }