Skip to content

Commit 9ac83f9

Browse files
committed
code review- rework, updated property names to match expected shape
1 parent a6874a6 commit 9ac83f9

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

specs/SHIELD.json

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1339,7 +1339,7 @@
13391339
"description": "Single configuration category with curated properties and values in a user-friendly format.",
13401340
"type": "object",
13411341
"properties": {
1342-
"categoryId": {
1342+
"id": {
13431343
"type": "string",
13441344
"description": "Internal Object ID in UUID format to uniquely identify this configuration category definition.",
13451345
"format": "uuid",
@@ -1350,7 +1350,7 @@
13501350
"6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a"
13511351
]
13521352
},
1353-
"name": {
1353+
"displayName": {
13541354
"type": "string",
13551355
"description": "Human friendly name of the Configuration Category.",
13561356
"examples": [
@@ -1409,13 +1409,13 @@
14091409
}
14101410
},
14111411
"required": [
1412-
"categoryId",
1413-
"name"
1412+
"id",
1413+
"displayName"
14141414
],
14151415
"examples": [
14161416
{
1417-
"categoryId": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a",
1418-
"name": "Identity Protection",
1417+
"id": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a",
1418+
"displayName": "Identity Protection",
14191419
"description": "Baseline controls that harden identity and access related workloads.",
14201420
"groupTagMetadataId": "5d3f9c2e-7a1b-4a8b-8c6e-1a3d7e8b5c4a",
14211421
"templateIds": [
@@ -1424,17 +1424,17 @@
14241424
]
14251425
},
14261426
{
1427-
"categoryId": "7e1a2b3c-4d5f-4a8b-9e6a-1c2b7f3d8e4a",
1428-
"name": "Conditional Access",
1427+
"id": "7e1a2b3c-4d5f-4a8b-9e6a-1c2b7f3d8e4a",
1428+
"displayName": "Conditional Access",
14291429
"parentCategoryId": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a"
14301430
}
14311431
]
14321432
},
14331433
"examples": [
14341434
[
14351435
{
1436-
"categoryId": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a",
1437-
"name": "Identity Protection",
1436+
"id": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a",
1437+
"displayName": "Identity Protection",
14381438
"description": "Baseline controls that harden identity and access related workloads.",
14391439
"groupTagMetadataId": "5d3f9c2e-7a1b-4a8b-8c6e-1a3d7e8b5c4a",
14401440
"templateIds": [
@@ -1443,8 +1443,8 @@
14431443
]
14441444
},
14451445
{
1446-
"categoryId": "7e1a2b3c-4d5f-4a8b-9e6a-1c2b7f3d8e4a",
1447-
"name": "Conditional Access",
1446+
"id": "7e1a2b3c-4d5f-4a8b-9e6a-1c2b7f3d8e4a",
1447+
"displayName": "Conditional Access",
14481448
"parentCategoryId": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a"
14491449
}
14501450
]
@@ -5480,8 +5480,8 @@
54805480
"summary": "Available Configuration Categories",
54815481
"value": [
54825482
{
5483-
"categoryId": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a",
5484-
"name": "Identity Protection",
5483+
"id": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a",
5484+
"displayName": "Identity Protection",
54855485
"description": "Baseline controls that harden identity and access related workloads.",
54865486
"groupTagMetadataId": "5d3f9c2e-7a1b-4a8b-8c6e-1a3d7e8b5c4a",
54875487
"templateIds": [
@@ -5490,8 +5490,8 @@
54905490
]
54915491
},
54925492
{
5493-
"categoryId": "7e1a2b3c-4d5f-4a8b-9e6a-1c2b7f3d8e4a",
5494-
"name": "Conditional Access",
5493+
"id": "7e1a2b3c-4d5f-4a8b-9e6a-1c2b7f3d8e4a",
5494+
"displayName": "Conditional Access",
54955495
"parentCategoryId": "6a2c7e1b-4d5f-4a8b-9e6a-2b1c7f3d8e4a"
54965496
}
54975497
]

0 commit comments

Comments
 (0)