Restore non-superadmin registry visibility on registry-server v1.4.1+#137
Merged
Conversation
Registry-server v1.4.1 (PR stacklok/toolhive-registry-server#762) flipped empty resource claims from "open" to "default-deny" when authz is configured. That hid the demo-registry row from alice/bob entirely because the registry definition carried no claims. Tag the demo-registry and k8s source rows with {groups: everyone} so all authenticated users pass the registry-level gate; per-entry authz-claims annotations continue to filter what each user actually sees. Also simplify the public registry to point at the same sources as demo-registry; toolhive-public was a curated subset that's unnecessary now that anonymous access via publicPaths bypasses every gate regardless. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
demo-registryrow carried no claims, so alice and bob saw zero servers in the cloud-UI while thedemosuper-admin still saw everything.demo-registryandk8ssource rows with{groups: everyone}. Every Keycloak user is a member ofeveryone, so all authenticated callers pass the registry-level gate. Per-entryauthz-claimsannotations continue to scope what each user actually sees.publicregistry to point at the same sources asdemo-registryand drop the dedicatedtoolhive-publicsource. Anonymous access viapublicPathsbypasses every claims gate regardless of what the sources carry, so a curated public-only filter list isn't pulling its weight.Test plan
validate-manifestsskill passes on the edited file/registry/public/v0.1/serversanonymously and confirm CLI flow still works