[BUG] Can not add 'Tax Amount' and 'Incl Tax Amount' columns to Transaction Table View

[dvdl16]

Current Behavior

If you customize your table column settings, and add the 'Tax Amount' or 'Incl Tax Amount' columns, you can not save the open document.

It shows an error message, ' Tax Amount is mandatory in row x' for cancelled GL Entries

Steps To Reproduce

1. Create a new VAT Return
2. Customize your table:
3. Get transactions, which includes at least one cancelled GL Entry
4. See error message

Expected Behavior

It should enforce the 'Mandatory Depends On' rule when correctly when those columns are in view:

The tax_amount field on Doctype 'Value-added Tax Return GL Entry' has a 'Mandatory Depends On (JS)' value of:

eval: doc.classification != "SARS Payment/Receipt" && !doc.is_cancelled

Anything else?

Perhaps frappe's 'Mandatory Depends On (JS)' doesn't actually work in Child Tables where the column is in view (I know it works when the row is expanded).

Perhaps just remove this 'Mandatory Depends On (JS)' and validate this server-side only

Environment and Versions

- Ccp Custom: v0.0.2 (HEAD)
- South Africa Customisations: v0.2.1 (HEAD)
- Digitnext: v0.3.1 (HEAD)
- ERPNext: v15.54.5 (HEAD)
- Frappe Framework: v15.71.0 (HEAD)
- Frappe HR: v15.47.8 (HEAD)
- Frappe Insights: v3.2.1 (HEAD)
- Frappe LMS: v2.32.2 (HEAD)

Operating System

Windows

What browsers are you seeing the problem on?

Firefox

[dvdl16]

The current workaround is to not include these columns in your table view