[BUG] WooCommerce Order Status is being changed even when sync feature turned off

[mepoland]

Current Behavior

If you have this option unchecked:

I would expect that ERPNext / WC Fusion will never mess with an order's status in WooCommerce. Instead, I'm finding that when you submit a Sales Order created by WC Fusion, it does push a status update to WooCommerce. Unfortunately the status it is pushing is always out of date.

Steps To Reproduce

1. Create an order in woocommerce; put it in Processing status
2. WC Fusion creates a Sales Order and sets woocommerce_status field to Processing.
3. In WooCommerce, update the order status to Completed.
4. Then submit the Sales Order in ERPNext (without updating the woocommerce_status field).
5. Now check the WooCommerce Order (and server request logs); its status will have changed back to Processing.

Expected Behavior

If the enable_so_status_sync checkbox is unchecked, do not allow ERPNext to change WooCommerce order statuses.

Anything else?

No response

Environment and Versions

ERPNext: v15.79.0 (HEAD)
Frappe Framework: v15.82.0 (HEAD)
WooCommerce Fusion: v1.15.2 (HEAD)

Operating System

Windows

What browsers are you seeing the problem on?

Chrome

[mepoland]

Relates to #83

[mepoland]

I forked this repo and tweaked a file to fix this issue. My goal is to entirely stop updates from getting pushed from SOs to WooCommerce, so this worked for me. But I realize the effect of my code doesn't perfectly match expected behavior:

• The WooCommerce Server option/checkbox says "don't sync order STATUS"
• My code below stops ANY info from getting pushed from SO to WC; including status, line item details, etc.
  This is desired for my use case because WC is generally the source of truth, and I don't want ERPNext messing with it. But I'm not sure how to best implement this in the WC Server options.

Anyway, I added the bottom 3 lines to update_woocommerce_order():

def update_woocommerce_order(self, wc_order: WooCommerceOrder, sales_order: SalesOrder) -> None:
		"""
		Update the WooCommerce Order with fields from it's corresponding ERPNext Sales Order
		"""
		wc_server = frappe.get_cached_doc("WooCommerce Server", wc_order.woocommerce_server)
		if not wc_server.enable_so_status_sync:
		    return  # Don't update status upstream if sync is disabled```

[OwenHook]

I have the same issue.