The anonymous landing page header does not follow the same style as the footer

[sgaist]

We are currently in the process of providing our own landing page.

From the tests we made, we saw that there's a header and a footer that are kept at all times and the content is put in between them (which is fine).

The footer has a dark background however the header has a transparent one which shows the background image through it. This currently means that when activating the custom content, a white based background is shown an thus the header only shows the Renku frog as the rest of the content is also white based. The buttons / menus are still there, just not properly visible.

I would suggest to make the header follow the footer in terms of styles and have it use the bg-navy class so they are kept in sync.

Side note, from a quick check, the header does not span the full window like the footer does. Thus adding the bg-navy class to the header object under the div rk-anon-home-hero is not enough however adding it to that div makes the whole block change which is not ideal either.

[lorenzo-cavazzi]

Hello @sgaist , thanks for your feedback!

The anonymous landing page has a custom layout with an unusual structure since the header element is nested inside the main content, unlike all the other pages. Your suggestions make sense; having a structure similar to the other pages (non-nested header taking all the width), with the background (and the theme) set as they are for the footer, will prevent the navbar from showing a white background.

In general, we didn't put much effort into updating the components for the custom content. Happy to hear someone is using that feature! Currently, we sanitize the markdown/HTML, but we shouldn't do that since the content is set by an admin and it makes sense to let e.g., classes be used for customizing the content.

I will create an issue to improve that. We are in the middle of a build cycle, so it might take a few weeks before we work on this. If you wish to speed up the process and work on this firsthand, please let me know and we can touch base about the changes.

[lorenzo-cavazzi]

@sgaist here is the reference issue #4094