From fe75984dde53386b0344ba00bc92a0a56e39567b Mon Sep 17 00:00:00 2001 From: IvanDSM Date: Wed, 14 Jan 2026 15:27:33 -0300 Subject: [PATCH 1/2] Add quotes on internal Lua include to fix build error This small commit just adds quotes around the Lua source path in the include statement when using the internal Lua engine. Without these quotes, my build was breaking when the FCEUX source was located in a path that contained spaces (e.g. "/home/ivan/Software/Source Code/fceux"). --- src/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 7a4326693..55a3f81f0 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -300,7 +300,7 @@ else () # Use Internal LUA message( STATUS "Using Internal Lua" ) - add_definitions( -D_S9XLUA_H -I${CMAKE_CURRENT_SOURCE_DIR}/lua/src ) + add_definitions( -D_S9XLUA_H -I"${CMAKE_CURRENT_SOURCE_DIR}/lua/src" ) set( LUA_ENGINE_SOURCE ${CMAKE_CURRENT_SOURCE_DIR}/lua/src/lapi.c From 094bfba3863c16a2af79721e048e6f132432bb5e Mon Sep 17 00:00:00 2001 From: IvanDSM Date: Wed, 14 Jan 2026 20:36:11 -0300 Subject: [PATCH 2/2] Add quotes to the Git macro definition generation script As with the Lua include issue, this script also needed quotes added in order to make building in paths with spaces possible. --- scripts/genGitHdr.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/genGitHdr.sh b/scripts/genGitHdr.sh index 8cfd35dd5..29ff0124d 100755 --- a/scripts/genGitHdr.sh +++ b/scripts/genGitHdr.sh @@ -19,15 +19,15 @@ echo "const char *fceu_get_git_rev(void){ return FCEUX_GIT_REV; }" >> $TMP_FILE echo "Git URL: $GIT_URL "; echo "Git Rev: $GIT_REV "; -if [ -e $OUTPUT_DIR/$FILE ]; then +if [ -e "$OUTPUT_DIR/$FILE" ]; then - diff -q $TMP_FILE $OUTPUT_DIR/$FILE + diff -q $TMP_FILE "$OUTPUT_DIR/$FILE" if [ $? != 0 ]; then - mv -f $TMP_FILE $OUTPUT_DIR/$FILE; + mv -f $TMP_FILE "$OUTPUT_DIR/$FILE"; echo "Updated $OUTPUT_DIR/$FILE"; fi else - mv -f $TMP_FILE $OUTPUT_DIR/$FILE + mv -f $TMP_FILE "$OUTPUT_DIR/$FILE" echo "Generated $OUTPUT_DIR/$FILE"; fi