Skip to content

docs(adr): close evidence json shape [D1]#3

Merged
Taleef7 merged 3 commits into
mainfrom
d1/adr-002-evidence-json
May 2, 2026
Merged

docs(adr): close evidence json shape [D1]#3
Taleef7 merged 3 commits into
mainfrom
d1/adr-002-evidence-json

Conversation

@Taleef7

@Taleef7 Taleef7 commented May 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • close ADR-002 on May 2 with the processor two-step evidence_json decision
  • record that D1 rechecked the finding against the CQF spike and Context7 docs

Decision

  • canonical evidence_json shape: expressionResults plus evaluatedResource
  • rule_path remains derived at render time, not persisted

Verification

  • ../workwell-spike-cqf: .\gradlew.bat test --tests com.workwell.spike.DualEvaluationCostSubSpikeTest -> BUILD SUCCESSFUL
  • git diff --cached --check -> exit 0

Copilot AI review requested due to automatic review settings May 2, 2026 21:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ADR-002 in docs/DECISIONS.md to record the final evidence_json decision and note an additional recheck of the CQF evidence before closing the ADR. It fits into the repository’s architectural documentation by clarifying how run-time evidence should be persisted and traced for the “Why Flagged” flow.

Changes:

  • Updates ADR-002’s recorded decision date from May 1 to May 2, 2026.
  • Expands the ADR context to note that D1 rechecked the decision against the CQF spike repo and Context7 docs.
  • Leaves the accepted processor two-step evidence_json decision and render-time rule_path[] derivation as the canonical approach.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/DECISIONS.md Outdated
Comment thread docs/DECISIONS.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@vercel

vercel Bot commented May 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workwell-measure-studio Ready Ready Preview, Comment May 2, 2026 9:24pm

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Taleef7 Taleef7 merged commit 0b74aa9 into main May 2, 2026
3 of 4 checks passed
@Taleef7 Taleef7 deleted the d1/adr-002-evidence-json branch May 2, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants