Idea for custom team-comps

[RomeoAlphaEkko]

instead of Checking for heavenly it checks for 2-star, 3-star and the green Penguin for those chosen champions from the teamplaner

why 2 and 3-star, cause the teamplaner is not shown once one needs to star up

[akshualy]

Solid idea. For the "star up", I'd like to cut out the stars and see if we can get transparency to work. (IIRC you were able to do this with opencv and numpy, but I'd have to read up on it again.) Otherwise I feel like matching won't be clear enough.

[RomeoAlphaEkko]

As they blink they might be overlooked once or twice but it worked prior to vanguard with those pings (not android)

[RomeoAlphaEkko]

Solid idea. For the "star up", I'd like to cut out the stars and see if we can get transparency to work. (IIRC you were able to do this with opencv and numpy, but I'd have to read up on it again.) Otherwise I feel like matching won't be clear enough.

i wanted to try getting the images and test them but i didnt get the teamplaner working, i cut it out normally, next time i used gimp for the picture to have the dpi from the emulator settings worked neither, what can i do (to help)

[akshualy]

You have to get an Emulator where you can take screenshots with the emulator, I know BlueStacks and LDPlayer have a "take a screenshot" button in the right navigation menu. Editing the images with GIMP is a good idea, other programs may remove some information. Other than that I can't really tell you what to do, as that's exactly what I do. In the actual logic, you can try to play around with the capture area and precision.

[RomeoAlphaEkko]

Tx I try it with the emulator screenshot tomorrow

edit: used the screenshot function of the emulator, once cut it to size with gimp the other train with paint, both didnt work T_T

[akshualy]

Could you upload the images you're trying to use here?

[RomeoAlphaEkko]

renamed heavenly to just replace the image of the trait searched for and not mess witht he code (thought it was the easiest way to check if the image worked

[akshualy]

Then the issue is probably that the trait check logic checks below the area where that icon would show, see here:

Alune/main.py

Lines 134 to 140 in 089b962

	for trait in config.get_traits():
	search_result = screen.get_on_screen(
	image=screenshot,
	path=trait,
	bounding_box=BoundingBox(170, 110, 1250, 230),
	precision=0.9,
	)

Updating that bounding box to start from Y 0 will probably fix it

[RomeoAlphaEkko]

well you know where to look 😒

well i fail either:

bounding_box=BoundingBox(0, 0, 0, 0),

or

bounding_box=BoundingBox(0),

let the program just close

[akshualy]

It's X1 Y1 X2 Y2, so the fix would be BoundingBox(170, 0, 1250, 230). If you want to play it safe, double-check pixel positions on a screenshot taken by the emulator.

[RomeoAlphaEkko]

tried counting it BoundingBox(170, 20, 1150, 70),

as it didnt shop first try neither do my values, i reduced the precision to 0.8 didnt work either T_T

[akshualy]

Additionally, this line may be an issue, the store card boxes are not that big to avoid misclicks:

Alune/main.py

Line 147 in 089b962

if not store_card.click_box.is_inside(search_result.get_middle()):

You can instead of search_result.get_middle() try Coordinate(search_result.x + search_result.width, search_result.y + search_result.height) (or write a method inside of ImageSearchResult called get_bottom_right that returns that coordinate.)