Skip to content

API: /v1/webhooks and /v1/admin/contracts are missing from the OpenAPI spec #569

Description

@Depo-dev

Two live routes are absent from api/openapi.yaml, so nothing generates SDKs for them and the contract test cannot catch a break.

Current behaviour

Neither path appears in the spec:

  • /v1/webhooks (GET, POST) — 0 matches in api/openapi.yaml
  • /v1/admin/contracts (GET, POST, DELETE) — 0 matches

Both are implemented and routed in services/api/main.go.

Why this matters now

GET /v1/webhooks recently changed from returning a bare JSON array to an enveloped object ({webhooks, has_more, next_cursor}) as part of the #220 pagination work. That is a breaking change for every existing client, and because the route is undocumented:

  • no SDK model exists for it in any of the five SDKs,
  • TestLiveOpenAPIContract cannot detect the change,
  • the break reaches users before it reaches CI.

This is the exact gap #421 and #232 describe, scoped to the two routes that are actually missing.

Scope

  • Document both paths with their real request/response schemas and status codes.
  • Regenerate SDK models so the envelope is represented.
  • Confirm the contract test covers them once documented.

Done when

  • Both routes are in the spec and exercised by the OpenAPI contract test.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    apiGo REST API + Rust gRPC APIdocumentationDocumentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions