Bug: bare except:pass in _publish_inline_comments_fallback_with_verification silently drops review comments

[karesansui-u]

Bug description

In github_provider.py L476-479, _publish_inline_comments_fallback_with_verification() uses except: pass when publishing verified review comments via pr.create_review():

if verified_comments:
    try:
        self.pr.create_review(commit=self.last_commit_id, comments=verified_comments)
    except:
        pass  # ← all exceptions silently swallowed

When this fails (GitHub API rate limit, network error, permission issue), the exception is swallowed. The caller publish_code_suggestions() believes the operation succeeded and returns True. The one-by-one retry path in pr_code_suggestions.py is never activated:

is_successful = self.git_provider.publish_code_suggestions(code_suggestions)
if not is_successful:
    # retry one by one ← never reached because publish returns True

Impact

• Review comments are silently lost with no error message to the user
• The retry mechanism specifically designed for this failure mode is bypassed
• This is particularly impactful because this is a PR review tool — its primary output (review comments) can disappear without any indication

Trigger conditions

Any GitHub API error during create_review:

• Rate limiting (HTTP 403)
• Network timeout
• Token permission issues
• GitHub server errors (HTTP 5xx)

Fix

PR #2258 — replace except: pass with except Exception as e: that logs and re-raises.

[qodo-free-for-open-source-projects]

💡 Auto-generated documentation-based answer:

The documentation provided here doesn’t cover internal implementation details like github_provider.py or the specific exception-handling behavior you’re describing, so it can’t confirm the bug or document PR #2258’s fix.

What the docs do provide for addressing/diagnosing “silent failures” in general:

• Increase/adjust logging verbosity via configuration:

  [config]
  log_level = "DEBUG"  # DEBUG/INFO/WARNING/ERROR/CRITICAL

• (Qodo Merge) Enable Sentry error monitoring in production to capture exceptions centrally:

  export SENTRY_DSN_PR_AGENT="https://..."
  export SENTRY_ENVIRONMENT="production"

• For debugging locally without publishing comments, you can disable publishing output:

  [config]
  publish_output=false
  verbosity_level=2

To give a more precise answer (and point to the right guidance), I’d need to know whether you’re running:

• self-hosted PR-Agent (CLI / GitHub Action / your own GitHub App server), or
• Qodo Merge (hosted GitHub App by Qodo),
  because the available logs/observability options and where to inspect them differs by deployment.

Relevant Sources:

• https://docs.qodo.ai/qodo-documentation/code-review/qodo-merge/usage-guide/additional_configurations#log-level
• https://docs.qodo.ai/qodo-documentation/code-review/qodo-merge/usage-guide/additional_configurations#sentry-error-monitoring
• https://docs.qodo.ai/qodo-documentation/code-review/qodo-merge/usage-guide/automations_and_usage#local-repo-cli