-
Notifications
You must be signed in to change notification settings - Fork 10
✏️ Refactor Providers Component #1165
Copy link
Copy link
Open
0 / 10 of 1 issue completedLabels
type: enhancementUpdate of existing codeUpdate of existing codetype: investigationInvestigating a new feature or issueInvestigating a new feature or issuetype: refactorRefactor of existing codeRefactor of existing code
Metadata
Metadata
Assignees
Labels
type: enhancementUpdate of existing codeUpdate of existing codetype: investigationInvestigating a new feature or issueInvestigating a new feature or issuetype: refactorRefactor of existing codeRefactor of existing code
Projects
StatusShow more project fields
📋 Backlog
Is your feature request related to a problem or need? Please describe.
Currently, the
Providerscomponent accepts ashowTypeandidprop and calls thegetTvProvidersorgetMovieProvidersrequests. Instead of passing the component the applicable data to render an individual provider.While this isn't inherently bad, with the ability to append
watch/providersto thegetTvDetailsandgetMovieDetails(which we're already doing), it may be better to pull the necessary data from those requests and pass it to the component. This would also eliminate a request.Additional context
The original thought with this component may have been to render providers based on the signed-in user's set country of origin, which would require the standalone
getWatchProvidersrequest. However, I'm not sure that we're prepared to implement that functionality. I believe thewatch/providersquery parameter defaults to US.Component implements
providers.results.US.flatrate.map()- hardcoded US providersProviders data included in

getTvProvidersandgetMovieProviders:Perhaps @Thenlie can opine on this, and this issue in general.