Skip to content

frontend: npm run lint fails on main — 39 lint errors in 3 recently-added test files, breaking Frontend CI #849

Description

@gboigwe

Summary

npm run lint currently fails with 39 errors (40 problems total) across 3 test files, meaning Frontend CI (a required auto-merge status check) is red on main right now.

Location

frontend/src/hooks/useTxNotifications.test.tsx, frontend/src/lib/tx-recovery.test.ts, frontend/src/lib/wallet.test.ts

Problem

These test files (added in earlier test-coverage fixes) use any extensively for mock typing, tripping @typescript-eslint/no-explicit-any dozens of times, plus at least one other lint rule. npm run lint currently exits non-zero.

Impact

Critical: Frontend CI failing on main blocks the whole CI-gated auto-merge premise for any PR depending on a clean baseline, and it's easy to miss since npm run typecheck and npm test can both pass while lint fails separately.

Acceptance Criteria

  • npm run lint passes with zero errors in frontend/
  • The fix replaces any with proper types (or narrowly-scoped unknown/generic mock types) rather than blanket-disabling the lint rule for these files
  • npm test still passes after the type changes (verify mocks still behave correctly)

Suggested Approach

Go file by file — wallet.test.ts and tx-recovery.test.ts first (fewer errors likely), then useTxNotifications.test.tsx. Most fixes will be replacing any mock parameter/return types with the actual types being mocked.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingcriticalProduction blockerfrontendNextjs frontend

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions