From 9d7377adac943dced66d6f37147a171782b36e34 Mon Sep 17 00:00:00 2001
From: badcuban <108198679+badcuban@users.noreply.github.com>
Date: Fri, 28 Aug 2026 01:29:53 -0400
Subject: [PATCH] fix(release): pass desktop build flags without the --
 separator

vite-plus 0.3.0 (bumped in #191) forwards a literal "--" to the script
instead of consuming it. The build script parses its flags with the
effect CLI, which reads "--" as the end of flags, so every flag after it
became an unexpected positional argument and all three nightly desktop
builds failed on the first run after the bump.

Drop the separator in the release and smoke workflows. Verified locally
with vp 0.3.0: "vp exec vp run dist:desktop:artifact --platform bogus"
now reaches the script's own validation.
---
 .github/workflows/desktop-smoke.yml | 2 +-
 .github/workflows/release.yml       | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/desktop-smoke.yml b/.github/workflows/desktop-smoke.yml
index 1da23acc4..54fe8bc39 100644
--- a/.github/workflows/desktop-smoke.yml
+++ b/.github/workflows/desktop-smoke.yml
@@ -127,7 +127,7 @@ jobs:
         run: vp install --frozen-lockfile
 
       - name: Build Linux AppImage
-        run: vp run dist:desktop:artifact -- --platform linux --target AppImage --arch x64 --build-version 0.2.2-smoke.0
+        run: vp run dist:desktop:artifact --platform linux --target AppImage --arch x64 --build-version 0.2.2-smoke.0
 
       - name: Boot AppImage and verify backend serves
         timeout-minutes: 3
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 51bf3ce68..58fcb5ee6 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -488,7 +488,7 @@ jobs:
           THREADLINES_POSTHOG_HOST: ${{ vars.THREADLINES_POSTHOG_HOST }}
           THREADLINES_TELEMETRY_ENABLED: ${{ vars.THREADLINES_TELEMETRY_ENABLED }}
         run: >
-          vp exec vp run dist:desktop:artifact --
+          vp exec vp run dist:desktop:artifact
           --platform win
           --target nsis
           --arch x64
@@ -665,7 +665,7 @@ jobs:
           chmod 600 "$apple_api_key_path"
           unset APPLE_API_KEY_CONTENT
 
-          APPLE_API_KEY="$apple_api_key_path" vp exec vp run dist:desktop:artifact -- \
+          APPLE_API_KEY="$apple_api_key_path" vp exec vp run dist:desktop:artifact \
             --platform mac \
             --target dmg \
             --arch "${{ matrix.arch }}" \
@@ -807,7 +807,7 @@ jobs:
           THREADLINES_POSTHOG_HOST: ${{ vars.THREADLINES_POSTHOG_HOST }}
           THREADLINES_TELEMETRY_ENABLED: ${{ vars.THREADLINES_TELEMETRY_ENABLED }}
         run: >
-          vp exec vp run dist:desktop:artifact --
+          vp exec vp run dist:desktop:artifact
           --platform linux
           --target AppImage
           --arch x64