Skip to content

CI check is (I think, to be verified) not enforced for new (v2.0+) branches #1036

Description

@thbar

GitHub has two ways to enforce things:

While looking into #1035, I believe we have currently:

  • the CI protection mechanism (CI must pass before a merge is possible) is active only for v1.3 (so: not useful), and uses the "old mode", see screenshot below
  • a new ruleset is in place for new branches, but does not enforce (at least not currently) CI errors (e.g. you can merge despite a CI failure, if I read correctly)

Will investigate later, but as a first conclusion: I will move the "parent check" from the general protection ruleset, into a dedicated ruleset, to fix #1035.

Screenshots

Useful to fix this & document.

Classic branch protection rules (only targeting v1.3 at the moment)

Details Image

New ruleset (incorrect)

Does not include CI check, if I'm correct. And also, currently includes (cause of #1035) the "parent status check" for all branches

Details Image

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions