Skip to content

is that a typo in base.py? #58

Description

@chivas1000

I have found in model/base.py
the direction prediction are using up1_embedding:
if self.direction_pred: x_direction = self.up1_embedded(x2, x1) x_direction = self.up2_direction(x_direction)

x_direction = self.up1_embedded(x2, x1)

why using up_1embedded blocks instead of using up1_direction as the up1_direction is already defined.
and will the weights of up1_embedded blocks are affected by the direction prediction?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions