Unify naming of operations in `nfa.hh`

[Adda0]

There are a few functions, such as Nfa::determinize() which operate on automata passed as a parameter and return a new automaton. There are also method, usually called Nfa::Nfa::get_..._automaton() or Nfa::Nfa::get_..._words, etc., e.g., Nfa::Nfa::get_one_letter_automaton(), which operate on the underlying automaton object and return a new automaton. Finally, there are methods which operate on the underlying automaton object and perform the operation in place (for example, Nfa::Nfa::trim()).

We should agree on whether we want to try to unify these variants, or when each variant can be used.

[Adda0]

There is a mismatch of names such as concatenate() (verb) and intersection() (noun). We should unify them.

Further suggestions are:

• Rename intersection_eps() to intersection_with_eps().
• Rename concatenate to concatenate_with_eps().
• Rename uni to something that at least slightly resembles union operation. Even unite() would be better.

[tfiedor]

I'm also strongly voting for renaming uni function. Like what...the...fuck????

[Adda0]

Definitely, I will add it to the list of names to change.

[Adda0]

We agreed that methods should compute operations in-place, if possible, functions should return a new instance, making the computation of the operation out-of-place, and both should use verbs for their names. Furthermore, the method and its corresponding function should be named the same.

[Adda0]

Should we add lang_union() (or something similar) as a single function to encapsulate calling operations union_nondet() and union_product() from #412, as discussed in #412 (comment)?

[koniksedy]

Should we add lang_union() (or something similar) as a single function to encapsulate calling operations union_nondet() and union_product() from #412, as discussed in #412 (comment)?

This has been done in #510.