Skip to content

fix: artifacts/addresses.json.example is missing a compliance contract entry #505

Description

Description

abis/ contains ABIs for compliance.json, invoice.json, and treasury.json, so artifacts/addresses.json.example (validated against script output in #269) should have a placeholder entry for all three deployed contract addresses; confirm compliance isn't missing given it's a newer contract than invoice/treasury.

This is part of the operational tooling under scripts/, the layer that turns manual, error-prone deployment and verification steps (per docs/MAINNET_DEPLOYMENT.md and docs/TESTNET_ONBOARDING.md) into repeatable, reviewable commands. Because several of these scripts run against mainnet or gate what CI considers a passing build, a bug or missing safeguard in one of them isn't just a developer-experience annoyance, it's a risk multiplier for whatever high-stakes operation the script is supposed to make safe.

Scripts in this category are also disproportionately under-tested relative to application code across most projects, this repository included, simply because shell scripts don't get the same default test-suite treatment that cargo test or npm test gets; that makes gaps here more likely to persist unnoticed until someone hits them during an actual deployment, which is the worst possible time to discover a scripting bug.

Requirements and context

  • Add a compliance key with a placeholder address if missing

Suggested execution

  1. Fork the repo and create a branch
    git checkout -b fix/addresses-example-add-compliance
    
  2. Implement changes
  • Update artifacts/addresses.json.example
  1. Test and commit
  • Run scripts/export_deployed_addresses.sh locally and diff against the example shape

Example commit message

fix: add missing compliance entry to addresses example file

Guidelines

  • Assignment required before starting
  • PR description must include: Closes #[issue_id]
  • Keep PR description professional and detailed

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions