Feature/issue 974 pagination validation#1103
Merged
Yunusabdul38 merged 3 commits intoJun 2, 2026
Merged
Conversation
|
@Dami24-hub is attempting to deploy a commit to the shola's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Dami24-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #974
This PR implements robust input validation for pagination query parameters (
limitandoffset) across the application's paginated endpoints. It ensures that incoming user data is safely typed and bounded before reaching the service layers, preventing potential DoS vectors (e.g., requesting massive limits) and database syntax errors.Changes Checklist
limitmust be an integer between 1 and 100;offsetmust be a non-negative integer.Proposed Changes
1. Validation Logic
limitandoffsetare valid integers.limit <= 100.limit > 0andoffset >= 0.400 Bad RequestHTTP status code with a descriptive error payload when validation fails.2. Testing Strategy
limit=50,offset=0), and maximum limit (limit=100).limit=abc), negative numbers (offset=-5), and exceeding the maximum threshold (limit=101).Verification Results
Automated Tests