Tardis Refined Nightly Bug

[TheSc0ob]

debug-2.log

debug-2.log

Issue description

The Arclight startup timing fix appears to be present saved TARDIS dimensions are restored during ServerStartedEvent, which absolutely avoids the original issue where dimensions were loaded too early.
However, (And the debug log supports this by showing refined only loaded 1 Tardis, but on shutdown 9 Tardis's were saved) there may still be a persistence bug in DimensionHandler. The in-memory DimensionHandler.LEVELS list starts empty each server run. When loadLevels() reads tardis_refined_tardis_info.json, it recreates missing levels, but if a Tardis level already exists, it logs it as loaded without appearing to re-add it to LEVELS. This potentially allows a later write to tardis_refined_tardis_info.json to omit older TARDIS dimension IDs. After working in my server for my players for weeks perfectly, all the sudden i got a ping today about 1 part of the 2 dimensions in their Tardis not loading, as well as their exterior not loading, we can forcibly teleport into the corridors but attempting to do so to the console room sends you into Fools stone. So im wondering if all saved Tardis dimension IDs survive restarts and remain listed in tardis_refined_tardis_info.json as this would track with that and if not, during loadLevels(), ensure every dimension read from tardis_refined_tardis_info.json is re added to the internal saved dimension list before any future writeLevels() call can overwrite the file

Steps to reproduce

Use Tardis Refined Nightly V2.1.6 1.20.1 on an Arclight server
Set up your Tardis, chill, fly, for like, 2-4 weeks.(Hopefully you have a companion)
Leave for a while, leave the server, wait for scheduled restarts and whatnot
Attempt entering Tardis if exterior even exists

Minecraft version

1.20.1

Mod Loader Platform type

Forge

Mod Loader version

Forge version 47.4.10 - Arclight-1.20.1-1.0.6-SNAPSHOT-166b7ad

Tardis Refined version

v2.1.6

Other relevant versions

No response

Mod List

No response

Please confirm that you have searched existing issues in the repo.

• Yes, I have checked all open issues and am aware my issue will be closed if it is a duplicate of another

Please confirm that if your issue is related to rendering, that you have tested without the following before testing; (Shaders, Optifine, Rubidium, embeddium, Sodium)

• Yes, I have done testing without these mods before reported a rendering issue or my issue does not relate to rendering

Attach the relevant crash report file or log file: (Don't know how to find a crash report file? See the Minecraft Wiki Tutorial

No response

[Acuadragon100]

Right, I don't think the tardis_refined_tardis_info.json is all that important though, all TARDIS dimensions are saved in level.dat anyway. I did notice the log mentioned something about a null TARDIS UUID, which implies some TARDIS didn't save properly. Could you send me the capabilities.dat file for the TARDIS that stopped working properly? You can find it under dimensions/tardis_refined/????????-????-????-????-????????????/data (make sure to select the directory named with the same UUID as the broken TARDIS). I don't know how much it will really tell me, but I'd like to have a look anyway.

[TheSc0ob]

Right, I don't think the tardis_refined_tardis_info.json is all that important though, all TARDIS dimensions are saved in level.dat anyway. I did notice the log mentioned something about a null TARDIS UUID, which implies some TARDIS didn't save properly. Could you send me the capabilities.dat file for the TARDIS that stopped working properly? You can find it under dimensions/tardis_refined/????????-????-????-????-????????????/data (make sure to select the directory named with the same UUID as the broken TARDIS). I don't know how much it will really tell me, but I'd like to have a look anyway.

---

It may not be, but i wouldnt really accept a "Therefore it doesnt matter" type logic to rule this out, level.dat may be enough for the server/minecraft to know the dimensions exist and load them as worlds, but tardis_refined_info.json is the mods own index of TARDIS dimensions. The mod explicitly reads it during startup and writes it later, so it clearly matters to the mods own tracking logic. In addition to that my log evidence matches that perfectly when my server/Arclight initializes 9 TARDIS dimensions, yet Tardis Refined DimensionHandler only attempted to load 1 and again that file is a part of the mods own internal tracking/indexing, even if level.dat is the lower-level Minecraft dimension source. As for the [Tardis Refined]: Error in saveAdditional: null Tardis ID (Invalid block or not terraformed yet?) [139, -1, 18] thats always normal for us when a tardis isnt terraformed yet, hence it saying that in the error as well, so i wouldnt worry about or look at that as a variable here.

[Acuadragon100]

Could you clarify what you meant by “not loading”? Did the exterior turn invisible or did the block disappear completely? When you said the dimension wasn’t loading, did you mean that the dimension disappeared completely, so it wouldn’t even show up in /execute in anymore, or was it just that the console room got replaced by fool’s stone?

Also, about the tardis_refined_tardis_info.json file. The way TARDIS Refined knows if a dimension is a TARDIS or not doesn’t really have anything to do with if it's in that file or not. Essentially, any dimension with the TARDIS Refined dimension type will be assigned TARDIS data (but if the dimension name is not a valid UUID it might crash). That file just tells TARDIS Refined to recreate the dimension if the dimension is removed from level.dat for some reason, which shouldn't happen unless you remove TARDIS Refined from the modpack and load the world without it.

[TheSc0ob]

So what me and my players were seeing was the exterior missing, only the corridor section of the interior would load if you tp'd into it with their homes or waystones, trying to enter the console room sends you to fools stone. And mmm understood, i saw that the server initialized 9 dimensions while refineds DimensionHandler only logged loading 1, so thats what led me down that way heavily. They definitely do exist in /execute in, so perhaps the more accurate issue is some tardis specific saved data, exterior link, generation state, or teleport target no longer matches whats on disc? I also think that because like i said ive used the nightly version for weeks to months with zero issues, but around the same time this happened my server shutdown later into the day from java.io.IOException: No space left on device due to a node issue on my hosts part, so thats definitely a detail i should have included to begin with here.

[Acuadragon100]

Yeah, it sounds a lot like something didn't save properly. You might be able to recreate the console room by just placing a console and changing the desktop theme.