Fix incorrect point placement in minibuffer when prefixed. #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can prefix an ag-command to pass additional arguments. If so, all the arguments will be prompted in the minibuffer for user editing and point is adjusted to the position for user's input. However, the calculation of the point position does not take the backslash (after shell-quote-argument) into account, nor the variable-length of the `:files' argument. This commit fixes this issue by searching for " -- " and place the cursor before it rather than subtracting a fixed value.
Author
|
This pull request tries to fix #159. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can prefix an ag-command to pass additional arguments. If so,
all the arguments will be prompted in the minibuffer for user editing
and point is adjusted to the position for user's input.
However, the calculation of the point position does not take the
backslash (after shell-quote-argument) into account, nor the
variable-length of the `:files' argument.
This commit fixes this issue by searching for " -- " and place the
cursor before it rather than subtracting a fixed value.