Wrong page links on search pages

[fragglet]

I reported this on the Discord but I figure it's worth filing an issue too.

On the search results page, the page links at the bottom of the page (to other pages of search results) sometimes link to random other searches instead. It looks like they're probably searches from other people who are using the site at the same time.

To reproduce:

1. Go to a search page, eg. https://winworldpc.com/search/?vendor=Microsoft&page=4
2. Scroll down to the bottom of the page and hover your mouse over one of the page links (eg. page 5) to see the URL being linked to
3. Refresh the page several times. you should see that the link is sometimes correct, but other times it shows links to random other searches instead

You can also reproduce the bug from the command line, with a command like:

curl https://winworldpc.com/search/\?vendor\=Microsoft\&page\=5 | grep page-link

This bug seems to have been present for quite a while; I found archive.org snapshots from 2023 where the links are wrong (example).

[fragglet]

Speculating on a possible cause: those links reference a variable named currentGET, as seen here:

adventure/adventure/views/search.ejs

Line 139 in 9bd6a72

<a class="page-link" href="/search/?<%= currentGET %>&page=1">1</a>

I've never used node.js so I don't know a lot about it, but I'd speculate it's probably a race condition related to that particular variable. If currentGET is set at the start of a query and another query starts being processed before the page finishes being generated, that would explain the behavior.