review修复：eval.dump抛出真实语法错误并pcall保护compat路径；undump失败时安全降级；nls注明适用范围

Author: sumneko

extension/package.nls.json

@@ -4,7 +4,7 @@
     "lua.debug.launch.console.integratedTerminal.description": "VS Code integrated terminal.",
     "lua.debug.launch.console.externalTerminal.description": "External terminal that can be configured in user settings.",
     "lua.debug.launch.luaVersion.description": "Default lua version.",
-    "lua.debug.launch.syntaxCompatibility.description": "Use the target Lua VM to parse source syntax for breakpoint line information.",
+    "lua.debug.launch.syntaxCompatibility.description": "Use the target Lua VM to parse source syntax for breakpoint line information. Note: only takes effect for Lua 5.3+ targets and requires a compatible bytecode format.",
     "lua.debug.launch.luaArch.description": "Default lua arch.",
     "lua.debug.launch.sourceCoding.description": "Source encoding.",
     "lua.debug.launch.path.description": "Search path for Lua programs",

extension/script/backend/worker/eval.lua

@@ -46,11 +46,14 @@ generate("dump", function()
     if luaver.LUAVERSION <= 52 then
         local compat_dump = assert(load(readfile 'backend.worker.eval.dump'))
         return function(content)
-            local res, err = compat_dump(content)
-            if res then
+            local ok, res, err = pcall(compat_dump, content)
+            if ok and res ~= nil then
                 return true, res
             end
-            return false, err
+            if ok then
+                return false, 'can not dump function.'
+            end
+            return false, res
         end
     else
         local eval_dump = assert(rdebug.load(readfile 'backend.worker.eval.dump'))

extension/script/backend/worker/eval/dump.lua

@@ -1,6 +1,6 @@
 local content = ...
-local f = load(content, "=eval.dump")
+local f, err = load(content, "=eval.dump")
 if not f then
-    return
+    error(err, 0)
 end
 return string.dump(f)

extension/script/backend/worker/parser.lua

@@ -110,7 +110,12 @@ return function (content, syntaxCompatibility)
         log.error("ERROR:"..(err or "unknown error"))
         return
     end
-    local cl, v = undump(bin)
+    local ok, cl, v = pcall(undump, bin)
+    if not ok then
+        local log = require 'common.log'
+        log.error("ERROR:"..tostring(cl))
+        return
+    end
     version = v
     local si = { activelines = {}, definelines = {} }
     local lineinfo = {}