[botlib] Compiler warning cleanup — unused variables, wrong types, orphaned file

[darkshade9]

The botlib produces many compiler warnings. Cleaning these up will help ensure real warnings are not missed.

Unused variables (-Wunused-variable, -Wunused-but-set-variable)

• botlib_cmd.c:13 — int cc
• botlib_ctf.c:325 — float flag2_dist
• botlib_esp.c:18 — edict_t *target
• botlib_movement.c:140 — qboolean foundProblem
• botlib_movement.c:4897 — qboolean not_infront
• botlib_movement.c:5049 — qboolean found_target
• botlib_movement.c:5240 — gitem_t *clweapon
• botlib_movement.c:6476 — int old_waterlevel
• botlib_spawn.c:329 — int prev_bots_skipped
• botlib_spawn.c:1728 — int i
• botlib_personality.c:370/397/398/539/540/614 — attempts, name, skin, chosen_weapon_index, highest_pref (x2)
• botlib_nodes.c:1801 — target_is_above, target_is_equal, higher
• botlib_nodes.c:3004/3007/3277/3562/3564/4142/4580/4759/4760/4761/5413 — multiple dead variables

Unused expression results (-Wunused-value)

These are bare statements that do nothing — likely placeholder code that was never completed:

• botlib_movement.c:4752-4759 — self->s.origin; / self->enemy->s.origin; / self->s.angles[PITCH]; (inside knife aiming block)
• botlib_nav.c:2650 — players[0]->client->pers.draw->draw_arrow_num; (bare read)

const qualifier stripping (-Wincompatible-pointer-types-discards-qualifiers)

vec3_origin (const vec3_t) passed to non-const vec3_t parameters:

• botlib_ai.c:317
• botlib_spawn.c:1631, 1703, 1752
• botlib_nodes.c:658

Fix: add const to affected function parameters or use a local zero vec3_t.

Wrong struct field type (-Wincompatible-pointer-types)

• g_local.h:870 — char* bot_file_path[MAX_QPATH] is an array of char pointers, but is used as a flat char buffer via strncpy. Should be: char bot_file_path[MAX_QPATH]

Orphaned source file

• src/action/botlib/botlib_win.c — not in meson.build, duplicates seed_random_number_generator already implemented in botlib_utils.c. Can be deleted.

[darkshade9]

Partially resolved in branch bot_cleanup. Here's what was fixed:

Unused variables — all resolved

• botlib_cmd.c — removed int cc
• botlib_ctf.c — flag2_dist was unused because of a same-variable tautology bug (flag1_dist < flag1_dist); fixed the comparison to flag1_dist < flag2_dist, which also resolved the unused variable
• botlib_esp.c — removed edict_t *target and its assignment block
• botlib_movement.c — removed foundProblem, not_infront (first instance only; second is legitimately used), found_target ×2, clweapon in BOTLIB_CrouchFire, old_waterlevel
• botlib_spawn.c — removed prev_bots_skipped and its increment; removed int i in BOTLIB_RemoveTeamplayBot
• botlib_personality.c — removed attempts, name, skin, chosen_weapon_index, highest_pref ×2
• botlib_nodes.c — removed target_is_above, target_is_equal, higher; removed fileSize/bsp_checksum in BOTLIB_LoadNavCompressed; removed unused vars in BOTLIB_SaveNav/BOTLIB_LoadNav/BOTLIB_NODE_REACHABILITY/BOTLIB_ProcesssReachabilities/BOTLIB_Process_NMesh

Bare expressions — all resolved

• botlib_movement.c — removed self->s.origin;, self->enemy->s.origin;, self->s.angles[PITCH];
• botlib_nav.c — removed players[0]->client->pers.draw->draw_arrow_num;

const qualifier stripping — partially resolved

• botlib_spawn.c:1631, 1703, 1752 — changed vec3_origin to (vec3_t){0,0,0} compound literal ✅
• botlib_nodes.c:BOTLIB_NodeTouchNodes — added const to normal parameter ✅
• botlib_ai.c:317 and botlib_nodes.c:658 — still pending

Wrong struct field type — resolved

• g_local.h:870 — fixed char* bot_file_path[MAX_QPATH] → char bot_file_path[MAX_QPATH]

Orphaned file — resolved

• botlib_win.c deleted; reference in botlib.h comment updated

Also fixed incidentally

• botlib_personality.c — selectedSkin == "" pointer comparison replaced with selectedSkin[0] != '\0'