-
Notifications
You must be signed in to change notification settings - Fork 0
New: Absorb adapt-authoring-sessions into auth module #73
Copy link
Copy link
Closed
Labels
Description
Chore
- Merge the
adapt-authoring-sessionsmodule intoadapt-authoring-auth
Rationale
As part of an ongoing effort to reduce the number of standalone modules (see adapt-security/adapt-authoring-core#112 for prior art), adapt-authoring-sessions is a strong candidate for absorption.
The module is a single 73-line file (SessionsModule.js) that wraps express-session with a connect-mongo store. It has no standalone purpose — sessions exist solely to support the auth lifecycle, and adapt-authoring-auth already depends on it as a peer dependency.
Approach
Following the pattern established in adapt-security/adapt-authoring-core#112:
- Move
SessionsModulelogic into the auth module as an internal library class (not anAbstractModulesubclass) - Absorb the
connect-mongoandexpress-sessiondependencies - Merge
errors.jsondefinitions into the auth error definitions - Merge config schemas into the auth config schema
- Merge documentation and doc plugins (jsdoc-style annotations) into auth
- Deprecate the standalone
adapt-authoring-sessionspackage
Reactions are currently unavailable