-
Notifications
You must be signed in to change notification settings - Fork 1
Revert serialised plugin installs once adapt-cli race condition is fixed #81
Copy link
Copy link
Open
Description
Context
In #80 we switched installPlugins from Promise.all (concurrent) to a sequential for...of loop as a workaround for a race condition in adapt-cli where multiple concurrent CLI commands read/write adapt.json simultaneously.
The underlying adapt-cli bugs are tracked in adaptlearning/adapt-cli#232:
readValidateJSONsilently swallows errors (returnsundefinedinstead of re-throwing)getManifestDependenciesdoesn't handleundefinedmanifestproject.add()has an unsafe read-modify-write cycle onadapt.json
Action
Once adaptlearning/adapt-cli#232 is resolved:
- Revert the
for...ofloop back toPromise.allininstallPluginsto restore concurrent plugin installation performance - Verify course imports with multiple plugins work correctly with concurrent installs
Why revert
Sequential installation is slower — each plugin waits for the previous one to complete. Concurrent installation is safe once the CLI properly handles concurrent file access.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels