MIDI tx.mox toggle stuck in TX on Linux/Pi - getter uses isMox() not isTransmitting()

[M8WLO]

When a MIDI button is mapped to MOX via the toggle sentinel (scaledValue == -1.0), pressing once turns TX on but a second press does not release it. Only the GUI can release TX.

Root Cause

The toggle sentinel reads the getter, flips it, then calls the setter. The tx.mox getter used isMox() which reads m_mox. The radio never sends mox= in transmit status messages (SmartSDR protocol v1.4.0.0 — documented in CLAUDE.md), so m_mox is always false. The getter always returns 0, the toggle always computes 1, and setTransmit(true) is called on every press — stuck in TX.

The FlexControl path at MainWindow.cpp:3545 already correctly used isTransmitting(). The MIDI path did not.

Fix

Change the tx.mox MIDI getter from isMox() to isTransmitting(). isTransmitting() is set optimistically by setTransmit() the moment the command is sent, so it immediately reflects toggle state.

Affected Platforms

Reproducible on Raspberry Pi / Linux with any MIDI controller mapped to MOX toggle.

[aethersdr-agent]

Triage — confirmed

The diagnosis in the report is correct on every point. Walked the code paths:

Getter path (broken): src/gui/MainWindow.cpp:14538-14540

reg("tx.mox", "MOX", "TX", P::Toggle, 0, 1,
    [this](float v) { m_radioModel.setTransmit(v > 0.5f); },
    [this]() -> float { return m_radioModel.transmitModel().isMox() ? 1 : 0; });

Why isMox() is stuck at false:

• TransmitModel::isMox() returns m_mox (src/models/TransmitModel.h:46, :283)
• m_mox is only written from a parsed mox= key in transmit status (src/models/TransmitModel.cpp:57-60)
• The radio never emits mox= in transmit status — confirmed by the inline note at MainWindow.cpp:10130-10138 and CLAUDE.md's SmartSDR v1.4.0.0 protocol section
• Therefore m_mox is permanently false; the toggle sentinel reads 0, computes 1 - 0 = 1, and calls setTransmit(true) on every press → stuck in TX

Why isTransmitting() is the correct getter:

• RadioModel::setTransmit() calls m_transmitModel.setTransmitting(tx) optimistically (src/models/RadioModel.cpp:1092), and TransmitModel::setMox() also writes m_transmitting directly (src/models/TransmitModel.cpp:432-433). So m_transmitting reflects user intent at the PTT edge, before any radio status round-trip.
• The FlexControl knob-button path already does this correctly at MainWindow.cpp:3546: m_radioModel.setTransmit(!m_radioModel.transmitModel().isTransmitting());
• The hardware-PTT path at MainWindow.cpp:3723 and MainWindow.cpp:12403 also use isTransmitting(). The MIDI registration is the lone outlier.

Proposed fix

One-line change at src/gui/MainWindow.cpp:14540:

 reg("tx.mox", "MOX", "TX", P::Toggle, 0, 1,
     [this](float v) { m_radioModel.setTransmit(v > 0.5f); },
-    [this]() -> float { return m_radioModel.transmitModel().isMox() ? 1 : 0; });
+    [this]() -> float { return m_radioModel.transmitModel().isTransmitting() ? 1 : 0; });

No other call sites of tx.mox exist — grep finds only this single registration.

Handoff

• Scope: 1 line, 1 file.
• Risk: Low. Aligns MIDI with the already-correct FlexControl and hardware-PTT paths. No protocol changes, no signal-wiring changes.
• Test: On Pi/Linux with a MIDI controller mapped to MOX toggle, press once (TX engages), press again (TX releases). GUI MOX button and S-meter should both follow.

Ready for aetherclaude-eligible if you'd like me to implement.

---

_{📍 Citation health check (Foundry Constitution Principle I): 6 resolved, 4 unresolved against /Users/aetherclaude/workspace/AetherSDR at origin/main.}

Unresolved citations (4)

Citation	Reason
MainWindow.cpp:10130-10138	file not found in workspace
MainWindow.cpp:12403	file not found in workspace
MainWindow.cpp:3546	file not found in workspace
MainWindow.cpp:3723	file not found in workspace