Skip to content

Post-merge verification: PR review commands (see-comments, reply-comment, review open/add/submit) #18

@rowan-stein

Description

@rowan-stein

Post-merge verification of PR review commands

Purpose: Run end-to-end live tests of the newly added commands against a temporary PR to confirm behavior on main.

Scope

  • Commands to verify:
    1. see-comments — list inline review comments by review id or latest
    2. reply-comment — reply by comment id (exercise the pending-review constraint behavior)
    3. review — open (GraphQL), add (GraphQL), submit (GraphQL)

Plan

  1. Create a short-lived test branch and PR with a small README change.
  2. Run review open to create a pending review; capture review id.
  3. Run review add to add an inline comment at the last line of README.md; verify thread created.
  4. Run review submit with event=COMMENT and a summary; verify submitted state.
  5. Run see-comments --latest to fetch the latest submitted review’s comments; confirm the inline comment id appears.
  6. Run reply-comment against the inline comment id; if 422 due to pending review state, first submit any pending review or use GraphQL thread reply, then retry and confirm success.
  7. Negative case: attempt to add to a non-existent review id and verify error handling.
  8. Close the test PR.

Deliverable

  • Post the terminal transcript (commands and outputs) and any relevant notes in a comment on this issue. Include the temporary PR link.

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions