-
Notifications
You must be signed in to change notification settings - Fork 17
Open
Description
Issue
Problem Description
This is some issues regarding PR #361 :
- There are no tests. However, the code looks good, and there are no apparent issues with it. Can we add an Issue of missing tests to keep track of that, then implement them at a later stage?
- No random seeds, for instance data_indices = np.random.choice(..), or train_test_split(...) in dts.py, which will make reproducability harder.
- Might be appropriate with a warining when users sets a too-low "clf_data_fraction". I think users will understand this without the warning but it might be a good add as a failsafe for runtime, when we are trying to mature the tool. A simple # After creating MIC dataset if len(self.mic_data) < 10: logger.warning(f"MIC dataset only has {len(self.mic_data)} samples...")
Expected Behavior
What Needs to be Done
How Can It Be Tested or Reproduced
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels