-
Notifications
You must be signed in to change notification settings - Fork 12
Description
Hi.
I noticed a problem with the method.
In the process of parsing the response, there is a condition that checks the values read from the Contents node. If at least one value is missing, the metadata is not added to the result.
https://github.com/aiokitchen/aiohttp-s3-client/blob/master/aiohttp_s3_client/xml.py#L75
According to Amazon's documentation, all expected values are optional. Although this may also apply to the nodes themselves.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_Object.html#API_Object_Contents
The same s3mock used in tests does not return the StorageClass node at all. That is, in tests, the method does not return anything and no real checking occurs.
I would not refuse help in solving this problem. Then I am ready to make corrections.