Open
Conversation
Collaborator
|
ready to merge? @ipmach |
Collaborator
|
There's multiple speeling issues, pls correct them or ask copilot to resolve them @ipmach |
Contributor
Author
yeah I know, this is currently a draft PR. It is not ready for review |
|
|
||
| Example of a configuration file: | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
this config is outdated with #54 ? no more log_variables
thorinaboenke
requested changes
Feb 16, 2026
Contributor
Author
|
Ok, now the branch is ready to review. However:
|
whotwagner
requested changes
Feb 18, 2026
| on: | ||
| push: | ||
| branches: [ "main", "development" ] | ||
| branches: [ "main"] |
Contributor
There was a problem hiding this comment.
Suggested change
| branches: [ "main"] | |
| branches: [ "main", "development"] |
| - name: Test with pytest | ||
| run: uv run --dev pytest -s | ||
|
|
||
| # include following code into the run section to match DetectMateService and DetectMateLibrary branches, if the name matches. |
There was a problem hiding this comment.
this should not be removed. This section determines which version of the DetectMateService should be pulled in for testing. If you are on main, it sets the service branch to main. Otherwise, it defaults to development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation to DetectMate.