Python 2/3 compatibility#18
Open
nvictus wants to merge 4 commits into
Open
Conversation
|
These changes look good on the face of it. I've only just found this now, having already made HiCPlotter exec and added the #!/bin/env python. Any reason for not merging? |
Owner
|
Million thanks to Nezar! 😃 |
akdemirlab
approved these changes
Jun 15, 2019
akdemirlab
approved these changes
Jun 15, 2019
akdemirlab
approved these changes
Jun 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably still incomplete and requires more testing, so maybe keep in another branch until ready. In short, the consequential changes:
HiCPlotter.py. Should have no effect on windows.__future__importsxrangereplaced withrangefor line in file.xreadlines()replaced withfor line in file:maxincmatrix = log2(pow(2, ceil(log2(max(matrix))/log2(2))))replaced withnp.nanmaxIssues that will probably arise will involve integer division and incompatibility of comparing objects of different types (e.g. int > list). Other hangups can most likely be resolved with the six package.
Style-wise, the changes are:
EDIT: oh, and also, fixed the default end point for read_Cooldata to
end = c.chromsizes[chrom], as we discussed :P