cd: push to shared-services ECR, drop environment#40
Merged
Conversation
Simplify the build/push workflow to a single CI flow:
- Remove the workflow_dispatch environment input, the detect-changes
ENVIRONMENT env + environment output, and the build-and-push environment key.
- Build the ECR repo path as ${ECR_REPOSITORY_PREFIX}-${SERVICE} (hyphen) to
match the shared-services repos strata/batch-exp-{backend,frontend}.
Requires repo settings: ECR_REPOSITORY_PREFIX=strata/batch-exp and AWS_ECR_ROLE
set to the shared-services push role (github-actions-checkpoint-explorer-push).
bewakes
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the build/push workflow to a single CI flow and points it at the shared-services ECR.
Changes (
.github/workflows/cd.yaml)workflow_dispatchenvironment input, thedetect-changesENVIRONMENTenv +environmentoutput, and thebuild-and-pushenvironment:key.ECR_REPOSITORYas\${ECR_REPOSITORY_PREFIX}-\${SERVICE}(hyphen) so it targetsstrata/batch-exp-backend/strata/batch-exp-frontend— the previous\$PREFIX/\${SERVICE}(slash) produced…/batch-exp/frontend, which doesn't exist in shared-services.Required repo settings (coordinated with this change)
ECR_REPOSITORY_PREFIX=strata/batch-expAWS_ECR_ROLE=arn:aws:iam::496607027995:role/github-actions-checkpoint-explorer-push(the dedicated least-privilege role, scoped to those two repos)With both set, CI builds push directly to shared-services and the manual master→shared mirror is no longer needed.
Note
Actions are still tag-pinned (
@v4/@v2/@v3); SHA-pinning can be a follow-up per CI hardening standards.