-
Notifications
You must be signed in to change notification settings - Fork 8
CI: compile/synth the CDK sample (not just parse it) #60
Copy link
Copy link
Open
Labels
area:ci.github/workflows, pre-commit, release automation.github/workflows, pre-commit, release automationhelp wantedMaintainers welcome a PR hereMaintainers welcome a PR hereiac:cdkAWS CDK (index.ts / index.js) scanning / fix outputAWS CDK (index.ts / index.js) scanning / fix outputtype:choreHousekeeping, tooling, CI, or repo configHousekeeping, tooling, CI, or repo config
Description
Metadata
Metadata
Assignees
Labels
area:ci.github/workflows, pre-commit, release automation.github/workflows, pre-commit, release automationhelp wantedMaintainers welcome a PR hereMaintainers welcome a PR hereiac:cdkAWS CDK (index.ts / index.js) scanning / fix outputAWS CDK (index.ts / index.js) scanning / fix outputtype:choreHousekeeping, tooling, CI, or repo configHousekeeping, tooling, CI, or repo config
Summary
The CDK sample's
package.jsonpinsaws-cdk-liband gets periodic Dependabot bumps, but there's no CI step that actually compiles the CDK sample (cdk synth/tsc). Add a lightweight check so a broken sample is caught.Why
samples/cdk/is used by the smoke test via--scan-only(which just parsesindex.tsas text), so a sample that no longer compiles would still pass smoke. Theiac-scanner-cdk-nagcompanion actually runscdk synth, so a broken sample breaks that path silently.What to do
npm ci && npx cdk synth(ortsc --noEmit) insamples/cdk/.Acceptance criteria
index.tswould fail the job (verify locally).Good first issue notes
Touches CI + a bit of Node tooling. Moderate.
area:ci,iac:cdk. Good if you're comfortable with npm/CDK.