From 796194b51e01d69b3bc6b008da76a6c1bc396d3f Mon Sep 17 00:00:00 2001
From: ankushchk <ankush@Ankushs-MacBook-Air-2.local>
Date: Thu, 26 Mar 2026 13:26:29 +0530
Subject: [PATCH] fix: password minlength mismatch and add email validation

Made-with: Cursor
---
 public/login.html | 12 ++++++++----
 src/worker.py     |  2 ++
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/public/login.html b/public/login.html
index b7d8c23..9b519c9 100644
--- a/public/login.html
+++ b/public/login.html
@@ -73,8 +73,8 @@ <h2 class="text-xl font-bold text-slate-800 mb-6">Create your account</h2>
         </div>
         <div>
           <label class="block text-sm font-medium text-slate-700 mb-1">Password</label>
-          <input id="r-password" type="password" autocomplete="new-password" required minlength="6"
-            class="w-full px-4 py-2.5 rounded-xl border border-slate-200 focus:outline-none focus:ring-2 focus:ring-brand/40 text-sm" placeholder="min 6 characters" />
+          <input id="r-password" type="password" autocomplete="new-password" required minlength="8"
+            class="w-full px-4 py-2.5 rounded-xl border border-slate-200 focus:outline-none focus:ring-2 focus:ring-brand/40 text-sm" placeholder="min 8 characters" />
         </div>
         <p id="register-err" class="text-red-500 text-sm hidden"></p>
         <button type="submit" class="w-full bg-brand text-white font-semibold py-2.5 rounded-xl hover:bg-brand-dark transition text-sm">Create Account</button>
@@ -125,14 +125,18 @@ <h2 class="text-xl font-bold text-slate-800 mb-6">Create your account</h2>
     e.preventDefault();
     document.getElementById('register-err').classList.add('hidden');
     const btn  = e.target.querySelector('button[type=submit]');
+    const email = document.getElementById('r-email').value.trim();
+    const pw    = document.getElementById('r-password').value;
+    if (!/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(email)) { showErr('register-err', 'Please provide a valid email address'); return; }
+    if (pw.length < 8) { showErr('register-err', 'Password must be at least 8 characters'); return; }
     btn.textContent = 'Creating...'; btn.disabled = true;
     try {
       const res  = await fetch('/api/register', { method:'POST', headers:{'Content-Type':'application/json'},
         body: JSON.stringify({
           name:     document.getElementById('r-name').value.trim(),
           username: document.getElementById('r-username').value.trim(),
-          email:    document.getElementById('r-email').value.trim(),
-          password: document.getElementById('r-password').value,
+          email:    email,
+          password: pw,
         }) });
       const data = await res.json();
       if (!res.ok) throw new Error(data.error || 'Registration failed');
diff --git a/src/worker.py b/src/worker.py
index 9656277..3de1ae0 100644
--- a/src/worker.py
+++ b/src/worker.py
@@ -563,6 +563,8 @@ async def api_register(req, env):
 
     if not username or not email or not password:
         return err("username, email, and password are required")
+    if not re.fullmatch(r"[^@\s]+@[^@\s]+\.[^@\s]+", email):
+        return err("Please provide a valid email address")
     if len(password) < 8:
         return err("Password must be at least 8 characters")