From 17905f51bf5d828ff889908ebf3f68812aab8ed3 Mon Sep 17 00:00:00 2001 From: JamBalaya56562 Date: Sun, 10 Aug 2025 12:29:20 +0900 Subject: [PATCH 1/2] docs: fix typos --- CHANGELOG.md | 6 +++--- README.md | 2 +- packages/cors/README.md | 2 +- packages/optimizer/README.md | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ecc9dd252..9bc2a229b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -129,7 +129,7 @@ * [#1140](https://github.com/ampproject/amp-toolbox/pull/1140) Enable ESM module version of AMP Runtime and Components by default ([@sebastianbenz](https://github.com/sebastianbenz)) * `page-experience` * [#1174](https://github.com/ampproject/amp-toolbox/pull/1174) PX: enable mobile device emulation ([@sebastianbenz](https://github.com/sebastianbenz)) - * [#1173](https://github.com/ampproject/amp-toolbox/pull/1173) PX:ignore invinsible elements ([@sebastianbenz](https://github.com/sebastianbenz)) + * [#1173](https://github.com/ampproject/amp-toolbox/pull/1173) PX:ignore invincible elements ([@sebastianbenz](https://github.com/sebastianbenz)) * [#1172](https://github.com/ampproject/amp-toolbox/pull/1172) PX: escape html in suggestions ([@sebastianbenz](https://github.com/sebastianbenz)) * [#1171](https://github.com/ampproject/amp-toolbox/pull/1171) PX: detect hero images ([@sebastianbenz](https://github.com/sebastianbenz)) * [#1168](https://github.com/ampproject/amp-toolbox/pull/1168) Check for early iframes ([@patrickkettner](https://github.com/patrickkettner)) @@ -720,7 +720,7 @@ - `cli`, `download-runtime` - [#663](https://github.com/ampproject/amp-toolbox/pull/663) download-runtime: Add tool to download AMP runtime ([@mdmower](https://github.com/mdmower)) - `cache-url`, `cli` - - [#666](https://github.com/ampproject/amp-toolbox/pull/666) Update CURLs hasing algorithm ([@sebastianbenz](https://github.com/sebastianbenz)) + - [#666](https://github.com/ampproject/amp-toolbox/pull/666) Update CURLs hashing algorithm ([@sebastianbenz](https://github.com/sebastianbenz)) - `optimizer` - [#636](https://github.com/ampproject/amp-toolbox/pull/636) optimizer: Output amp-geo API meta tags ([@mdmower](https://github.com/mdmower)) @@ -762,7 +762,7 @@ - [#649](https://github.com/ampproject/amp-toolbox/pull/649) Encode JSON values ([@sebastianbenz](https://github.com/sebastianbenz)) - [#618](https://github.com/ampproject/amp-toolbox/pull/618) Fix: auto extension import amp-access-laterpay & amp-subscriptions-google ([@sebastianbenz](https://github.com/sebastianbenz)) - `linter` - - [#626](https://github.com/ampproject/amp-toolbox/pull/626) Test explicitly for existance of value ([@dritter](https://github.com/dritter)) + - [#626](https://github.com/ampproject/amp-toolbox/pull/626) Test explicitly for existence of value ([@dritter](https://github.com/dritter)) #### :house: Internal diff --git a/README.md b/README.md index 0ead76e06..60f089ab0 100644 --- a/README.md +++ b/README.md @@ -89,7 +89,7 @@ npm run test:node -- packages/optimizer ### Style & Linting -This codebase adheres to the [Google Javascript Styleguide](https://google.github.io/styleguide/jsguide.html) and is enforced using ESLint. ESLint is run as part of the test suite, but you can also explicity run it via: +This codebase adheres to the [Google Javascript Styleguide](https://google.github.io/styleguide/jsguide.html) and is enforced using ESLint. ESLint is run as part of the test suite, but you can also explicitly run it via: ``` # run ESLint diff --git a/packages/cors/README.md b/packages/cors/README.md index 69e661bc5..28b329e40 100644 --- a/packages/cors/README.md +++ b/packages/cors/README.md @@ -84,7 +84,7 @@ app.use(ampCors({ ### Logging -For debugging requests, you can enable the verbose loggin mode via the `verbose` option: +For debugging requests, you can enable the verbose logging mode via the `verbose` option: ``` app.use(ampCors({ diff --git a/packages/optimizer/README.md b/packages/optimizer/README.md index d95850973..0d01bc061 100644 --- a/packages/optimizer/README.md +++ b/packages/optimizer/README.md @@ -244,7 +244,7 @@ Enables hero image optimization. Hero images will either be auto detected or you The maximum number of hero images that can be marked up using `data-hero` is `2`. This number can be increased using the `maxHeroImageCount` parameter. -Hero images are optimized by server-side rendering the `img` element inside the `amp-img` element. This can siginificantly improve image rendering performance and reduce the [largest contentful paint](https://web.dev/lcp/) (LCP) metric from [Core Web Vitals](https://web.dev/vitals/). +Hero images are optimized by server-side rendering the `img` element inside the `amp-img` element. This can significantly improve image rendering performance and reduce the [largest contentful paint](https://web.dev/lcp/) (LCP) metric from [Core Web Vitals](https://web.dev/vitals/). - name: `optimizeHeroImages` - valid options: `[true|false]` From 92c2c6ecb295690f81ca35046e89391542fb864c Mon Sep 17 00:00:00 2001 From: JamBalaya56562 Date: Tue, 12 Aug 2025 10:32:14 +0900 Subject: [PATCH 2/2] revert: update changelog.md --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bc2a229b..ecc9dd252 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -129,7 +129,7 @@ * [#1140](https://github.com/ampproject/amp-toolbox/pull/1140) Enable ESM module version of AMP Runtime and Components by default ([@sebastianbenz](https://github.com/sebastianbenz)) * `page-experience` * [#1174](https://github.com/ampproject/amp-toolbox/pull/1174) PX: enable mobile device emulation ([@sebastianbenz](https://github.com/sebastianbenz)) - * [#1173](https://github.com/ampproject/amp-toolbox/pull/1173) PX:ignore invincible elements ([@sebastianbenz](https://github.com/sebastianbenz)) + * [#1173](https://github.com/ampproject/amp-toolbox/pull/1173) PX:ignore invinsible elements ([@sebastianbenz](https://github.com/sebastianbenz)) * [#1172](https://github.com/ampproject/amp-toolbox/pull/1172) PX: escape html in suggestions ([@sebastianbenz](https://github.com/sebastianbenz)) * [#1171](https://github.com/ampproject/amp-toolbox/pull/1171) PX: detect hero images ([@sebastianbenz](https://github.com/sebastianbenz)) * [#1168](https://github.com/ampproject/amp-toolbox/pull/1168) Check for early iframes ([@patrickkettner](https://github.com/patrickkettner)) @@ -720,7 +720,7 @@ - `cli`, `download-runtime` - [#663](https://github.com/ampproject/amp-toolbox/pull/663) download-runtime: Add tool to download AMP runtime ([@mdmower](https://github.com/mdmower)) - `cache-url`, `cli` - - [#666](https://github.com/ampproject/amp-toolbox/pull/666) Update CURLs hashing algorithm ([@sebastianbenz](https://github.com/sebastianbenz)) + - [#666](https://github.com/ampproject/amp-toolbox/pull/666) Update CURLs hasing algorithm ([@sebastianbenz](https://github.com/sebastianbenz)) - `optimizer` - [#636](https://github.com/ampproject/amp-toolbox/pull/636) optimizer: Output amp-geo API meta tags ([@mdmower](https://github.com/mdmower)) @@ -762,7 +762,7 @@ - [#649](https://github.com/ampproject/amp-toolbox/pull/649) Encode JSON values ([@sebastianbenz](https://github.com/sebastianbenz)) - [#618](https://github.com/ampproject/amp-toolbox/pull/618) Fix: auto extension import amp-access-laterpay & amp-subscriptions-google ([@sebastianbenz](https://github.com/sebastianbenz)) - `linter` - - [#626](https://github.com/ampproject/amp-toolbox/pull/626) Test explicitly for existence of value ([@dritter](https://github.com/dritter)) + - [#626](https://github.com/ampproject/amp-toolbox/pull/626) Test explicitly for existance of value ([@dritter](https://github.com/dritter)) #### :house: Internal