Fix/tmux manager dead pane on restart#105
Merged
Merged
Conversation
Root cause: portable-pty's UnixMasterWriter::drop() sends newline + EOF (Ctrl-D) to the PTY master when dropped. When the PTY hosts a tmux attach-session, that EOF is forwarded by the tmux client to the active pane inside the tmux session, causing the pane's shell to exit cleanly with status 0. This only affects panes the user 'clicked into' because tmux forwards input to the active pane. Fix: implement Drop on PtyBackend that: 1. Sends SIGHUP explicitly to the child process group for proper hangup signaling 2. Replaces the writer with a no-op sink and forgets the original to prevent the EOF write from executing The writer's FD is leaked but closed when the master PTY FD drops or when the process exits. This path only runs during window/app cleanup.
When a plugin sets a tab title via applyTabTitle, mark the tab with pluginRenamed=true. The onTitleChange callbacks in tab-manager.js now skip overwriting when this flag is set, preventing shell OSC escape sequences from replacing the plugin's intended tab name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Testing
cargo build --release -p conch_tauri)Notes for reviewer