add support for array#34
Open
alichherawalla wants to merge 1 commit into
Open
Conversation
alichherawalla
force-pushed
the
master
branch
3 times, most recently
from
b5d1f1d to
e862289
Compare
alichherawalla
force-pushed
the
master
branch
from
e862289 to
446c13d
Compare
|
Any chance of getting @alichherawalla 's commit merged? I'm having the exact same issue. |
Author
|
@anantab Would it be possible to please review this PR? |
dapriett
approved these changes
Feb 24, 2022
Author
|
Thanks for the review @dapriett Possible to please merge since I don't have write access |
Author
|
Hi @alichherawalla, sorry for the late reply. Unfortunately, I'm not one of the maintainers. Doesn't appear this repo is still being maintained. But your change looked good to me. I was running into the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for this amazing library. It has truly made my life much simpler.
Currently, if I exclude an array element, it is replaced with null. For a certain use case my Cloudformation template breaks due to the null replacement. Hence if the item is an array I iterate over it and splice the index that isn't required