Option to load specific icons from system theme

[Gotolei]

So it looks for nvidia-power-indicator-intel.svg and nvidia-power-indicator-nvidia.svg in the appropriate panel/status folder, instead of just scanning the whole theme for anything containing intel or nvidia. Would make it possible for icon themes to have the indicator fully match.

Another, possibly simpler couple of alternatives could be

1. allow to use user-created icons in the .config folder
2. allow user-specified icon names in .cfg

[andrebrait]

Hey there @Gotolei.

These ideas have came up in my mind more than once. While it can be done, I won't have time to implement this until December/January.

Regarding the way it looks for icons, it actually looks for icons containing intel and nvidia in the theme, or at leats it tries to.

https://github.com/andrebrait/nvidia-power-indicator/blob/master/usr/lib/nvidia-power-indicator/nvidia-power-indicator#L74-L85

This section of code does this. It looks for icons for intel and nvidia in the icon theme used by the user. It there are none, it uses the normal colored icons.

Maybe you have found a bug. Which icon theme are you using and which DE are you running?

[Gotolei]

Papirus icons, XFCE

And no, it's working just as intended as far as I can tell. There's only one icon in the theme with intel in the name, and that one's being loaded just fine. The problem is that while it does find an icon with nvidia in the name, since it chooses only the largest size it ends up using a certain nvidia-settings.svg (which is a bright green 48x48 square in the apps folder) instead of the better-fitting prime-nvidia.svg in the panel folder.

[andrebrait]

I see. If you want to do it for yourself as a temporary solution, change line 82 of the script to

self.nvidia_icon = theme.lookup_icon('prime-nvidia', max(theme.get_icon_sizes('prime-nvidia')), 0).get_filename()

I'm aware that this is a sub-optimal solution as it is and I'll improve it in the future.

[andrebrait]

It used to work fine the way I had it in the beginning (with a custom icon theme folder which had icons for intel and nvidia, leaving the selection itself to GTK), but something changed in KDE in later versions (5.8, I think) that broke the way custom icon folders work. I didn't have much time, so I just reported the bug to the KDE team and fixed it the best (easy) way I could find at the time. When I finish my report and finals I'll get back to fixing this kind of thing/including other options so advanced users can choose which icon to use.