fix: restore release version source after marketplace decommission#26
Merged
Conversation
The decommission set conventional-changelog-action to skip-version-file, which made it lose the current-version baseline and recompute from git as 1.1.0 -> tag collision -> release failed. Add version.json as the dedicated version file (seed 1.9.0 = current release). The action reads/bumps it; the 2b step still syncs SKILL.md frontmatter from $VERSION. No marketplace.json dependency reintroduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #25 (decommission) set
conventional-changelog-actionskip-version-file: true. Without a version file the action recomputed the version from git as 1.1.0, hit the pre-existingv1.1.0tag, and the post-merge release failed (run 25985392387). No bad commit/tag was pushed; master is clean at778dfcbbut the decommission is unreleased and the pipeline is broken.Fix
version.json({"version":"1.9.0"}) - dedicated version file, seeded at the current release so the action bumps from the right baseline. No marketplace.json dependency.automated-release.yml:version-file: ./version.json,version-path: version,skip-version-file: false. 2b step still syncs SKILL.md frontmatter from $VERSION;git addnow includesversion.json.Effect
Commits since
v1.9.0= decommissionchore:+ thisfix:-> patch -> v1.9.1, fresh tag (no collision). SKILL.md frontmatter synced. marketplace.json stays deleted.Note
This corrects a deviation in the approved plan: the plan/my first attempt assumed
skip-version-filewas sufficient; the action actually needs a version file for the current baseline. version.json is the minimal correct artifact.