Skip to content

Commit 460ced6

Browse files
test(io): drop a wrong reason from a DeleteFiles test comment
Arrow's S3FileSystem::DeleteFile issues a HEAD first and fails with PathNotFound for a missing key, so deleting a missing key does not succeed through this path. The read-back check stays; only its stated reason was wrong.
1 parent bc689cc commit 460ced6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/iceberg/test/arrow_s3_file_io_test.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,8 +428,8 @@ TEST_F(ArrowS3FileIOTest, DeleteFilesReachesEveryCredentialPrefix) {
428428
ASSERT_THAT(io->WriteFile(path, "payload"), IsOk());
429429
}
430430
ASSERT_THAT(io->DeleteFiles(paths), IsOk());
431-
// Deleting a missing key succeeds on S3, so check the objects are gone. The
432-
// writes above authenticated on these paths, so a failed read means absent.
431+
// The writes above authenticated on these paths, so a failed read means the
432+
// object is gone.
433433
for (const auto& path : paths) {
434434
EXPECT_FALSE(io->ReadFile(path, std::nullopt).has_value()) << path;
435435
}

0 commit comments

Comments
 (0)